linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm -v9 3/3] mm, THP, swap: Enable THP swap optimization only if has compound map
Date: Wed, 19 Apr 2017 12:00:29 -0400	[thread overview]
Message-ID: <20170419160029.GB3376@cmpxchg.org> (raw)
In-Reply-To: <20170419070625.19776-4-ying.huang@intel.com>

On Wed, Apr 19, 2017 at 03:06:25PM +0800, Huang, Ying wrote:
> From: Huang Ying <ying.huang@intel.com>
> 
> If there is no compound map for a THP (Transparent Huge Page), it is
> possible that the map count of some sub-pages of the THP is 0.  So it
> is better to split the THP before swapping out. In this way, the
> sub-pages not mapped will be freed, and we can avoid the unnecessary
> swap out operations for these sub-pages.
> 
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> ---
>  mm/swap_state.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/swap_state.c b/mm/swap_state.c
> index 3a3217f68937..b025c9878e5e 100644
> --- a/mm/swap_state.c
> +++ b/mm/swap_state.c
> @@ -192,9 +192,15 @@ int add_to_swap(struct page *page, struct list_head *list)
>  	VM_BUG_ON_PAGE(!PageLocked(page), page);
>  	VM_BUG_ON_PAGE(!PageUptodate(page), page);
>  
> -	/* cannot split, skip it */
> -	if (unlikely(PageTransHuge(page)) && !can_split_huge_page(page, NULL))
> -		return 0;
> +	if (unlikely(PageTransHuge(page))) {
> +		/* cannot split, skip it */
> +		if (!can_split_huge_page(page, NULL))
> +			return 0;
> +		/* fallback to split huge page firstly if no PMD map */
> +		if (!compound_mapcount(page) &&
> +		    split_huge_page_to_list(page, list))
> +			return 0;
> +	}

This looks good to me, but could you please elaborate the comment a
little bit with what you have in the changelog? Something like:

	/*
	 * Split pages without a PMD map right away. Chances are
	 * some or all of the tail pages can be freed without IO.
	 */

  reply	other threads:[~2017-04-19 16:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19  7:06 [PATCH -mm -v9 0/3] THP swap: Delay splitting THP during swapping out Huang, Ying
2017-04-19  7:06 ` [PATCH -mm -v9 1/3] mm, THP, swap: Delay splitting THP during swap out Huang, Ying
2017-04-19 15:52   ` Johannes Weiner
2017-04-20  0:43     ` Huang, Ying
2017-04-21  6:11   ` Balbir Singh
2017-04-21  7:21     ` Huang, Ying
2017-04-21 14:08     ` Johannes Weiner
2017-04-22  0:07       ` Huang, Ying
2017-04-19  7:06 ` [PATCH -mm -v9 2/3] mm, THP, swap: Check whether THP can be split firstly Huang, Ying
2017-04-19 16:13   ` Johannes Weiner
2017-04-20  0:50     ` Huang, Ying
2017-04-20 20:50       ` Johannes Weiner
2017-04-21  0:34         ` Huang, Ying
2017-04-19  7:06 ` [PATCH -mm -v9 3/3] mm, THP, swap: Enable THP swap optimization only if has compound map Huang, Ying
2017-04-19 16:00   ` Johannes Weiner [this message]
2017-04-20  0:51     ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170419160029.GB3376@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ying.huang@intel.com \
    --subject='Re: [PATCH -mm -v9 3/3] mm, THP, swap: Enable THP swap optimization only if has compound map' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).