From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934400AbdDSQ0w (ORCPT ); Wed, 19 Apr 2017 12:26:52 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:39490 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763422AbdDSQ0u (ORCPT ); Wed, 19 Apr 2017 12:26:50 -0400 Date: Wed, 19 Apr 2017 17:26:36 +0100 From: Mark Brown To: Biaoyong Hu Cc: Joe Perches , Liam Girdwood , linux-kernel@vger.kernel.org, byhoo Message-ID: <20170419162636.c3azoi5ijaopqffg@sirena.org.uk> References: <1492529974-4332-1-git-send-email-hubiaoyong@gmail.com> <20170418154947.tuom2jg5hwcpzje2@sirena.org.uk> <1492532921.8661.42.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="htysknadqce6hvqf" Content-Disposition: inline In-Reply-To: X-Cookie: Could I have a drug overdose? User-Agent: NeoMutt/20170306 (1.8.0) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator/core.c: remove the else statement X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --htysknadqce6hvqf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 19, 2017 at 08:53:05PM +0800, Biaoyong Hu wrote: > kfree(pin); pin will be freed. So, "pin->request_count = 0;" should be > removed? Yes, it's redundant. Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. --htysknadqce6hvqf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlj3j7sACgkQJNaLcl1U h9D/Zgf9GNtIV69ye0PSHIyQhwnzdVXLM6XYbqShQstMMnSUZT8KmryY5qgkHNW3 6C3fBXg4NGNizOGQs8fBsq4mVrWCsC2vWzt27xe6OlfaPMM60qY5nZKwsWgj7z1r X+GKgLvolNZ9/BXLzwWBjgIBSKrtUcw8oQ6/x0lMW33UV9kJ3We8C2S5dW+j9yEr VMWhHcyCb1cmPk33yBcbyryK+/wza6ZWd59vBwz9P5iPRlZO+jJzXPjhemmxrkev AodjFYlU1c0cyiBbTpd7AApK29sD+8dvQvbIc7w01+BqRnp6hNWoftuCO3O8wK56 3zA+nHNYBC3UyJYO5PS+Sh8VC+pLgA== =hVsn -----END PGP SIGNATURE----- --htysknadqce6hvqf--