From: Keith Busch <email@example.com> To: Andrei Vagin <firstname.lastname@example.org> Cc: email@example.com, Thomas Gleixner <firstname.lastname@example.org>, Xiaolong Ye <email@example.com> Subject: Re: irq/affinity: Fix extra vecs calculation Date: Wed, 19 Apr 2017 13:03:59 -0400 [thread overview] Message-ID: <20170419170359.GE16224@localhost.localdomain> (raw) In-Reply-To: <20170419162027.GA7428@outlook.office365.com> On Wed, Apr 19, 2017 at 09:20:27AM -0700, Andrei Vagin wrote: > Hi, > > Something is wrong with this patch. We run CRIU tests for upstream kernels. > And we found that a kernel with this patch can't be booted. > > https://travis-ci.org/avagin/linux/builds/223557750 > > We don't have access to console logs and I can't reproduce this issue on > my nodes. I tired to revert this patch and everything works as expected. > > https://travis-ci.org/avagin/linux/builds/223594172 > > Here is another report about this patch > https://lkml.org/lkml/2017/4/16/344 Yikes, okay, I've made a mistake somewhere. Sorry about that, I will look into this ASAP. If it's a divide by 0 as your last link indicates, that must mean there are possible nodes, but have no CPUs, and those should be skipped. If that's the case, the following should fix it, but I'm going to do some more qemu testing with various CPU topologies to confirm. --- diff --git a/kernel/irq/affinity.c b/kernel/irq/affinity.c index d052947..80c45d0 100644 --- a/kernel/irq/affinity.c +++ b/kernel/irq/affinity.c @@ -105,6 +105,9 @@ irq_create_affinity_masks(int nvecs, const struct irq_affinity *affd) /* Calculate the number of cpus per vector */ ncpus = cpumask_weight(nmsk); + if (!ncpus) + continue; + vecs_to_assign = min(vecs_per_node, ncpus); /* Account for rounding errors */ --
next prev parent reply other threads:[~2017-04-19 16:55 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-13 17:28 [PATCH] " Keith Busch 2017-04-13 21:46 ` [tip:irq/urgent] " tip-bot for Keith Busch 2017-04-19 16:20 ` Andrei Vagin 2017-04-19 17:03 ` Keith Busch [this message] 2017-04-19 19:11 ` Andrei Vagin 2017-04-19 19:53 ` Andrei Vagin 2017-04-19 21:53 ` Keith Busch 2017-04-19 22:32 ` Andrei Vagin 2017-04-19 22:45 ` Keith Busch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170419170359.GE16224@localhost.localdomain \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: irq/affinity: Fix extra vecs calculation' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).