From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938627AbdDSRwb (ORCPT ); Wed, 19 Apr 2017 13:52:31 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:52271 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938047AbdDSRw3 (ORCPT ); Wed, 19 Apr 2017 13:52:29 -0400 Date: Wed, 19 Apr 2017 19:52:27 +0200 From: Alexandre Belloni To: Arnd Bergmann Cc: Nicolas Ferre , Boris Brezillon , Lee Jones , Wei Yongjun , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused Message-ID: <20170419175227.x4uow3mhcweagpza@piout.net> References: <20170419174824.4134087-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170419174824.4134087-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/2017 at 19:48:07 +0200, Arnd Bergmann wrote: > We get a harmless warning without CONFIG_PM: > > drivers/memory/atmel-ebi.c:584:12: error: 'atmel_ebi_resume' defined but not used [-Werror=unused-function] > > Marking the function as __maybe_unused does the right thing here > and drops it silently when unused. > > Fixes: a483fb10e5ea ("memory: atmel-ebi: Add PM ops") > Signed-off-by: Arnd Bergmann Sure, Acked-by: Alexandre Belloni I think you can safely take it through arm-soc directly. > --- > drivers/memory/atmel-ebi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/atmel-ebi.c b/drivers/memory/atmel-ebi.c > index 35910f945bfa..99e644cda4d1 100644 > --- a/drivers/memory/atmel-ebi.c > +++ b/drivers/memory/atmel-ebi.c > @@ -581,7 +581,7 @@ static int atmel_ebi_probe(struct platform_device *pdev) > return of_platform_populate(np, NULL, NULL, dev); > } > > -static int atmel_ebi_resume(struct device *dev) > +static __maybe_unused int atmel_ebi_resume(struct device *dev) > { > struct atmel_ebi *ebi = dev_get_drvdata(dev); > struct atmel_ebi_dev *ebid; > -- > 2.9.0 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com