From: Arnd Bergmann <arnd@arndb.de>
To: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>
Cc: Arnd Bergmann <arnd@arndb.de>,
Vinay Simha BN <simhavcs@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Hoegeun Kwon <hoegeun.kwon@samsung.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] drm/panel: S6E3HA2 needs backlight code
Date: Wed, 19 Apr 2017 19:59:18 +0200 [thread overview]
Message-ID: <20170419175939.189098-2-arnd@arndb.de> (raw)
In-Reply-To: <20170419175939.189098-1-arnd@arndb.de>
The new S6E3HA2 driver fails to link when backlight is disabled:
ERROR: "backlight_device_register" [drivers/gpu/drm/panel/panel-samsung-s6e3ha2.ko] undefined!
ERROR: "backlight_device_unregister" [drivers/gpu/drm/panel/panel-samsung-s6e3ha2.ko] undefined!
This adds a Kconfig dependency like we have it for some other panel drivers.
Fixes: ed29f9426d9b ("drm/panel: Add support for S6E3HA2 panel driver on TM2 board")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 3e29a9903303..6eb9774284df 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -66,6 +66,7 @@ config DRM_PANEL_SAMSUNG_S6E3HA2
tristate "Samsung S6E3HA2 DSI video mode panel"
depends on OF
depends on DRM_MIPI_DSI
+ depends on BACKLIGHT_CLASS_DEVICE
select VIDEOMODE_HELPERS
config DRM_PANEL_SAMSUNG_S6E8AA0
--
2.9.0
next prev parent reply other threads:[~2017-04-19 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 17:59 [PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency Arnd Bergmann
2017-04-19 17:59 ` Arnd Bergmann [this message]
2017-04-19 18:03 ` [PATCH 3/3] drm/panel: add backlight dependency for sitronix-st7789v Arnd Bergmann
2017-06-14 18:13 ` Thierry Reding
2017-06-14 18:13 ` [PATCH 2/3] drm/panel: S6E3HA2 needs backlight code Thierry Reding
2017-04-19 20:21 ` [PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency Laurent Pinchart
2017-04-19 20:39 ` Arnd Bergmann
2017-04-20 9:01 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170419175939.189098-2-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hoegeun.kwon@samsung.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=simhavcs@gmail.com \
--cc=thierry.reding@gmail.com \
--subject='Re: [PATCH 2/3] drm/panel: S6E3HA2 needs backlight code' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).