From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968882AbdDSSMv (ORCPT ); Wed, 19 Apr 2017 14:12:51 -0400 Received: from mail-wr0-f172.google.com ([209.85.128.172]:36459 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968867AbdDSSMs (ORCPT ); Wed, 19 Apr 2017 14:12:48 -0400 Date: Wed, 19 Apr 2017 20:12:43 +0200 From: Daniel Lezcano To: Arnd Bergmann Cc: Mark Rutland , Marc Zyngier , Thomas Gleixner , Christoffer Dall , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused Message-ID: <20170419181243.GA2523@mai> References: <20170419173737.3846098-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170419173737.3846098-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 19, 2017 at 07:37:09PM +0200, Arnd Bergmann wrote: > In some rare randconfig builds, we end up with two functions being entirely > unused: > > drivers/clocksource/arm_arch_timer.c:342:12: error: 'erratum_set_next_event_tval_phys' defined but not used [-Werror=unused-function] > static int erratum_set_next_event_tval_phys(unsigned long evt, > drivers/clocksource/arm_arch_timer.c:335:12: error: 'erratum_set_next_event_tval_virt' defined but not used [-Werror=unused-function] > static int erratum_set_next_event_tval_virt(unsigned long evt, > > We could add an #ifdef around them, but we would already have to check for > several symbols there and there is a chance this would get more complicated > over time, so marking them as __maybe_unused is the simplest way to avoid the > harmless warnings. > > Fixes: 01d3e3ff2608 ("arm64: arch_timer: Rework the set_next_event workarounds") > Signed-off-by: Arnd Bergmann > --- Acked-by: Daniel Lezcano