From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969142AbdDSSuZ (ORCPT ); Wed, 19 Apr 2017 14:50:25 -0400 Received: from mga01.intel.com ([192.55.52.88]:13631 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S969051AbdDSSuV (ORCPT ); Wed, 19 Apr 2017 14:50:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,222,1488873600"; d="scan'208";a="91823331" Date: Wed, 19 Apr 2017 11:50:01 -0700 From: Andi Kleen To: Arnaldo Carvalho de Melo Cc: Andi Kleen , jolsa@kernel.org, linux-kernel@vger.kernel.org, eranian@google.com Subject: Re: [PATCH] perf, tools: Fix display of data source snoop indication Message-ID: <20170419185001.GJ4021@tassilo.jf.intel.com> References: <20170419174940.13641-1-andi@firstfloor.org> <20170419184613.GA3929@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170419184613.GA3929@kernel.org> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 19, 2017 at 03:46:13PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu: > > From: Andi Kleen > > > > perf mem report doesn't display the data source snoop indication correctly. > > > > In the kernel API the definition is > > missing something? #define PERF_MEM_SNOOP_NONE 0x02 /* no snoop */ #define PERF_MEM_SNOOP_HIT 0x04 /* snoop hit */ #define PERF_MEM_SNOOP_MISS 0x08 /* snoop miss */ > > > but the table used by the perf tools exchanged Hit and Miss > > > > "None", > > "Miss", > > "Hit", > > > > Fix the table in perf. > > > > Cc: eranian@google.com > > Signed-off-by: Andi Kleen > > --- > > tools/perf/util/mem-events.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c > > index 1d4ab53c60ca..865ba3c39284 100644 > > --- a/tools/perf/util/mem-events.c > > +++ b/tools/perf/util/mem-events.c > > @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info) > > static const char * const snoop_access[] = { > > "N/A", > > "None", > > - "Miss", > > "Hit", > > + "Miss", > > "HitM", > > }; > > > > -- > > 2.9.3