From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969311AbdDSUMa (ORCPT ); Wed, 19 Apr 2017 16:12:30 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:37689 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S969295AbdDSUM2 (ORCPT ); Wed, 19 Apr 2017 16:12:28 -0400 Date: Wed, 19 Apr 2017 13:12:26 -0700 From: Darren Hart To: Andy Shevchenko Cc: Carlo Caione , Carlo Caione , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" , Linux Upstreaming Team Subject: Re: [PATCH 2/2] hp-wmi: Fix detection for dock and tablet mode Message-ID: <20170419201226.GB17351@fury> References: <20170409135608.15621-1-carlo@caione.org> <20170409135608.15621-3-carlo@caione.org> <20170413182150.GI2064@fury> <20170413230749.GA11189@fury> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 19, 2017 at 07:23:39PM +0300, Andy Shevchenko wrote: > On Fri, Apr 14, 2017 at 2:07 AM, Darren Hart wrote: > > On Thu, Apr 13, 2017 at 10:09:43PM +0200, Carlo Caione wrote: > >> On Thu, Apr 13, 2017 at 8:21 PM, Darren Hart wrote: > >> > On Sun, Apr 09, 2017 at 03:56:08PM +0200, Carlo Caione wrote: > > > EINVAL is being used to broadly here. If the input values are incorrect, then > > yes -EINVAL is the right response. However, if the query was unsuccessful, that > > is more appropriately -EIO. > > > > If the handle/method doesn't exist, that would be -ENXIO. > > > > However, your changes make the driver self-consistent and I'll apply them as is > > to testing. > > Darren, if it's not yet in for-next, I would like Carlo to update his > patch 1. I think it's better if we not shadow negative error code from > the callee. See my response in the V2 Carlo submitted. -- Darren Hart VMware Open Source Technology Center