From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969848AbdDSVxl (ORCPT ); Wed, 19 Apr 2017 17:53:41 -0400 Received: from mail.kernel.org ([198.145.29.136]:37316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968127AbdDSVxk (ORCPT ); Wed, 19 Apr 2017 17:53:40 -0400 Date: Wed, 19 Apr 2017 18:53:33 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen , eranian@google.com Subject: Re: [PATCH] perf, tools: Fix display of data source snoop indication Message-ID: <20170419215332.GB3929@kernel.org> References: <20170419195337.14575-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170419195337.14575-1-andi@firstfloor.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Apr 19, 2017 at 12:53:37PM -0700, Andi Kleen escreveu: > From: Andi Kleen > > perf mem report doesn't display the data source snoop indication correctly. > > In the kernel API the definition is I fixed this already, prepending the lines starting with # with two spaces, so that it doesn't vanishes one 3rd time 8-) - Arnaldo > but the table used by the perf tools exchanged Hit and Miss > > "None", > "Miss", > "Hit", > > Fix the table in perf. > > Cc: eranian@google.com > Signed-off-by: Andi Kleen > --- > tools/perf/util/mem-events.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c > index 1d4ab53c60ca..865ba3c39284 100644 > --- a/tools/perf/util/mem-events.c > +++ b/tools/perf/util/mem-events.c > @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info) > static const char * const snoop_access[] = { > "N/A", > "None", > - "Miss", > "Hit", > + "Miss", > "HitM", > }; > > -- > 2.9.3