From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S944072AbdDTJhC (ORCPT ); Thu, 20 Apr 2017 05:37:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42804 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943758AbdDTJhA (ORCPT ); Thu, 20 Apr 2017 05:37:00 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2F32A61D09 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2F32A61D09 Date: Thu, 20 Apr 2017 11:36:56 +0200 From: Jiri Olsa To: Jin Yao Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v6 0/7] perf report: Show branch type Message-ID: <20170420093656.GA28272@krava> References: <1492690075-17243-1-git-send-email-yao.jin@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492690075-17243-1-git-send-email-yao.jin@linux.intel.com> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 20 Apr 2017 09:36:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2017 at 08:07:48PM +0800, Jin Yao wrote: > v6: > Update according to the review comments from > Jiri Olsa . Major modifications are: > > 1. Move that multiline conditional code inside {} brackets. > > 2. Move branch_type_stat_display() from builtin-report.c to > branch.c. Move branch_type_str() from callchain.c to > branch.c. > > 3. Keep the original branch info display order, that is: > predicted, abort, cycles, iterations for the tools part Acked-by: Jiri Olsa thanks, jirka