Re: [GIT PULL 00/28] perf/core fixes and cleanups

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	David Ahern <dsahern@gmail.com>,
	Jean Pihet <jean.pihet@linaro.org>, Jiri Olsa <jolsa@kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Wang Nan <wangnan0@huawei.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [GIT PULL 00/28] perf/core fixes and cleanups
Date: Thu, 20 Apr 2017 15:51:26 -0300	[thread overview]
Message-ID: <20170420185126.GF3929@kernel.org> (raw)
In-Reply-To: <20170420182954.GE3929@kernel.org>

Em Thu, Apr 20, 2017 at 03:29:54PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Apr 20, 2017 at 02:10:58PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Thu, Apr 20, 2017 at 01:29:26PM +0200, Ingo Molnar escreveu:
> > > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > > Em Thu, Apr 20, 2017 at 10:10:49AM +0200, Ingo Molnar escreveu:
> > > > > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > > > > Pulled, thanks a lot Arnaldo!
> > > > > 
> > > > > > For this specific pull request the samples/bpf/ was disabled, as 'make headers_install'
> > > > > > is failing with the following error, in this case in fedora:rawhide:
> > > > > >   
> > > > > >     INSTALL usr/include/uapi/ (0 file)
> > > > > >   /git/linux/scripts/Makefile.headersinst:62: *** Missing generated UAPI file 
> > > > > ./arch/x86/include/generated/uapi/asm/unistd_32.h.  Stop.
> > > > > >   make[1]: *** [/git/linux/Makefile:1151: headers_install] Error 2
> > > > > >   make[1]: Leaving directory '/tmp/build/linux'
> > > > > >   make: *** [Makefile:152: sub-make] Error 2
> > > > > >   make: Leaving directory '/git/linux'
> > > > > 
> > > > > Beyond this build fix,
> > > > 
> > > > I haven't checked this lately, will do, hopefully this was already taken
> > > > care of by someone dealing with the headers_install code.
> > > 
> > > Ah, sorry, I thought it's a problem introduced by perf - if it's an existing 
> > > upstream bug then never mind!
> > 
> > 
> > Now if I try outside the container, on a fedora:25 system, same result:
> > 
> > [acme@jouet linux]$ rm -rf /tmp/build/linux
> > [acme@jouet linux]$ mkdir /tmp/build/linux
> > [acme@jouet linux]$ make O=/tmp/build/linux allmodconfig 

<SNIP>

> > /home/acme/git/linux/scripts/Makefile.headersinst:62: *** Missing generated UAPI file ./arch/x86/include/generated/uapi/asm/unistd_64.h.  Stop.
> > /home/acme/git/linux/Makefile:1149: recipe for target 'headers_install' failed
> > make[1]: *** [headers_install] Error 2
> > make[1]: Leaving directory '/tmp/build/linux'
> > Makefile:152: recipe for target 'sub-make' failed
> > make: *** [sub-make] Error 2
> > [acme@jouet linux]$ 
> > 
> > Trying to investigate this further now... Perhaps I'm missing something
> > :-\
> 
> So, it seems that headers_install needs to have as a dependency the
> target that generates those headers (/generated/), as it works if I
> actually start building the kernel and then do the headers_install
> step.

> that or allmodconfig is broken, probably the former, checking...

Well, I tried using 'make defconfig' instead of 'make allmodconfig' and
things are back working...

Now debian:experimental is again building all the tests.

Will use that and reenable building samples/bpf/ in all the recent
enough distro containers.

- Arnaldo