From: Darren Hart <email@example.com> To: Andy Shevchenko <firstname.lastname@example.org> Cc: Andy Shevchenko <email@example.com>, Platform Driver <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Carlo Caione <email@example.com> Subject: Re: [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups Date: Thu, 20 Apr 2017 13:19:43 -0700 [thread overview] Message-ID: <20170420201943.GA3209@fury> (raw) In-Reply-To: <CAHp75VfrOxBA6hbEds-dQaAtGcMaRhNo=tSZT+gnMeAASEasmA@mail.gmail.com> On Thu, Apr 20, 2017 at 10:38:56AM +0300, Andy Shevchenko wrote: > On Thu, Apr 20, 2017 at 5:25 AM, Darren Hart <firstname.lastname@example.org> wrote: > > From: "Darren Hart (VMware)" <email@example.com> > > > > This series factors out some redundant code, cleans up a number of style issues, > > modernizes the sysfs usage, and cleans up the return paths. All told, the driver > > is reduced in size by 37 lines (3.6%). > > > > I do not have an HP laptop, so I'm hoping Carlo can help out with some testing. > > In particular we need to verify that hotkeys and sysfs continue to work as > > before. > > > > Series looks good to me except patch 2. So, > > Reviewed-by: Andy Shevchenko <firstname.lastname@example.org> > > with above exception. I was on the fence with this one, which is why I separated it out. I'll drop it. Thanks for the review. -- Darren Hart VMware Open Source Technology Center
next prev parent reply other threads:[~2017-04-20 20:19 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-20 2:25 Darren Hart 2017-04-20 2:25 ` [PATCH 1/9] platform/x86: hp-wmi: Cleanup local variable declarations Darren Hart 2017-04-20 2:25 ` [PATCH 2/9] platform/x86: hp-wmi: Add bios_args initializer Darren Hart 2017-04-20 7:37 ` Andy Shevchenko 2017-04-20 2:25 ` [PATCH 3/9] platform/x86: hp-wmi: Standardize enum usage for constants Darren Hart 2017-04-20 7:19 ` Andy Shevchenko 2017-04-20 20:31 ` Darren Hart 2017-04-20 2:25 ` [PATCH 4/9] platform/x86: hp-wmi: Refactor redundant HPWMI_READ functions Darren Hart 2017-04-20 2:25 ` [PATCH 5/9] platform/x86: hp-wmi: Cleanup wireless get_(hw|sw)state functions Darren Hart 2017-04-20 2:25 ` [PATCH 6/9] platform/x86: hp-wmi: Refactor dock and tablet state fetchers Darren Hart 2017-04-20 2:25 ` [PATCH 7/9] platform/x86: hp-wmi: Use DEVICE_ATTR_(RO|RW) helper macros Darren Hart 2017-04-20 2:25 ` [PATCH 8/9] platform/x86: hp-wmi: Do not shadow errors in sysfs show functions Darren Hart 2017-04-20 2:25 ` [PATCH 9/9] platform/x86: hp-wmi: Cleanup exit paths Darren Hart 2017-04-20 7:38 ` [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups Andy Shevchenko 2017-04-20 20:19 ` Darren Hart [this message] 2017-04-20 9:06 ` Carlo Caione
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170420201943.GA3209@fury \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v1 0/9] platform/x86: hp-wmi: Driver refactoring and cleanups' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).