From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1036104AbdDUHaV convert rfc822-to-8bit (ORCPT ); Fri, 21 Apr 2017 03:30:21 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:38327 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1036030AbdDUHaT (ORCPT ); Fri, 21 Apr 2017 03:30:19 -0400 From: Juergen Borleis Organization: Pengutronix e.K. To: Florian Fainelli Subject: Re: [PATCH net-next] net: dsa: Remove redundant NULL dst check Date: Fri, 21 Apr 2017 09:29:44 +0200 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , "David S. Miller" , open list References: <20170420224723.6916-1-f.fainelli@gmail.com> In-Reply-To: <20170420224723.6916-1-f.fainelli@gmail.com> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <201704210929.45552.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:5e26:aff:fe2b:7cc4 X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, On Friday 21 April 2017 00:47:22 Florian Fainelli wrote: > tag_lan9303.c does check for a NULL dst but that's already checked by > dsa_switch_rcv() one layer above. > > Signed-off-by: Florian Fainelli > --- > net/dsa/tag_lan9303.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/net/dsa/tag_lan9303.c b/net/dsa/tag_lan9303.c > index 563b6c8fe445..70130ed5c21a 100644 > --- a/net/dsa/tag_lan9303.c > +++ b/net/dsa/tag_lan9303.c > @@ -79,11 +79,6 @@ static struct sk_buff *lan9303_rcv(struct sk_buff > *skb, struct net_device *dev, struct dsa_switch *ds; > unsigned int source_port; > > - if (unlikely(!dst)) { > - dev_warn_ratelimited(&dev->dev, "Dropping packet, due to missing switch tree device\n"); > - return NULL; > - } > - > ds = dst->ds[0]; > > if (unlikely(!ds)) { Thanks! Acked-by: Juergen Borleis -- Pengutronix e.K.                             | Juergen Borleis             | Industrial Linux Solutions                   | http://www.pengutronix.de/  |