From: Steven Rostedt <rostedt@goodmis.org>
To: luca abeni <luca.abeni@santannapisa.it>
Cc: Juri Lelli <juri.lelli@arm.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Claudio Scordino <claudio@evidence.eu.com>,
Tommaso Cucinotta <tommaso.cucinotta@sssup.it>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH] sched/deadline: fix switching to -deadline
Date: Fri, 21 Apr 2017 09:39:48 -0400 [thread overview]
Message-ID: <20170421093948.14c7b5d8@gandalf.local.home> (raw)
In-Reply-To: <20170421115421.5d51a12b@nowhere>
On Fri, 21 Apr 2017 11:54:21 +0200
luca abeni <luca.abeni@santannapisa.it> wrote:
> On Fri, 21 Apr 2017 11:42:40 +0200
> luca abeni <luca.abeni@santannapisa.it> wrote:
> [...]
> > > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> > > > index a2ce590..ec53d24 100644
> > > > --- a/kernel/sched/deadline.c
> > > > +++ b/kernel/sched/deadline.c
> > > > @@ -950,6 +950,10 @@ enqueue_dl_entity(struct sched_dl_entity
> > > > *dl_se, update_dl_entity(dl_se, pi_se);
> > > > else if (flags & ENQUEUE_REPLENISH)
> > > > replenish_dl_entity(dl_se, pi_se);
> > > > + else if ((flags & ENQUEUE_RESTORE) &&
> > >
> > > Not sure I understand how this works. AFAICT we are doing
> > > __sched_setscheduler() when we want to catch the case of a new
> > > dl_entity (SCHED_{OTHER,FIFO} -> SCHED_DEADLINE}, but queue_flags
> > > (which are passed to enqueue_task()) don't seem to have
> > > ENQUEUE_RESTORE set?
> >
> > I was under the impression sched_setscheduler() sets
> > ENQUEUE_RESTORE...
>
> __sched_setscheduler() sets queue_flags to DEQUEUE_SAVE, which matches
> ENQUEUE_RESTORE (see comments in sched/sched.h), so things should work
> correctly, right?
I was tripping over this too, but missed the comments in sched/sched.h.
Probably want to stick a comment about this in here as well.
-- Steve
next prev parent reply other threads:[~2017-04-21 13:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 19:30 [PATCH] sched/deadline: fix switching to -deadline luca abeni
2017-04-21 9:39 ` Juri Lelli
2017-04-21 9:42 ` luca abeni
2017-04-21 9:47 ` Juri Lelli
2017-04-21 9:59 ` luca abeni
2017-04-21 10:18 ` Peter Zijlstra
2017-04-21 10:26 ` Juri Lelli
2017-04-21 19:08 ` luca abeni
2017-04-24 10:16 ` Juri Lelli
2017-04-24 10:36 ` Luca Abeni
2017-04-24 10:53 ` Juri Lelli
2017-04-21 10:17 ` Peter Zijlstra
2017-04-21 9:54 ` luca abeni
2017-04-21 13:39 ` Steven Rostedt [this message]
2017-07-24 7:49 ` Luca Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421093948.14c7b5d8@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@redhat.com \
--cc=claudio@evidence.eu.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tommaso.cucinotta@sssup.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).