From: "Horia Geantă" <horia.geanta@nxp.com>
To: <gregkh@linuxfoundation.org>, Roy Pledge <roy.pledge@nxp.com>
Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
Haiying Wang <haiying.wang@nxp.com>,
Ioana Radulescu <ruxandra.radulescu@nxp.com>,
Stuart Yoder <stuyoder@gmail.com>
Subject: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command
Date: Fri, 21 Apr 2017 15:00:18 +0300 [thread overview]
Message-ID: <20170421120018.22232-1-horia.geanta@nxp.com> (raw)
When checking the response verb, the valid bit should be masked out,
since its value flips depending on what Response Register
(RR0 /RR1) it's been read from.
Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2")
Signed-off-by: Horia Geantă <horia.geanta@nxp.com>
---
drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
index 2a3ea29d9b43..5d020fb98c66 100644
--- a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
+++ b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
@@ -963,7 +963,7 @@ int qbman_swp_alt_fq_state(struct qbman_swp *s, u32 fqid,
}
/* Decode the outcome */
- WARN_ON(r->verb != alt_fq_verb);
+ WARN_ON((r->verb & 0x7f) != alt_fq_verb);
/* Determine success or failure */
if (unlikely(r->rslt != QBMAN_MC_RSLT_OK)) {
--
2.12.0.264.gd6db3f216544
next reply other threads:[~2017-04-21 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 12:00 Horia Geantă [this message]
2017-04-21 13:31 ` [PATCH] bus: fsl-mc: dpio: fix alter FQ state command Stuart Yoder
2017-04-21 13:50 ` Horia Geantă
2017-04-21 14:47 ` Dan Carpenter
2017-04-22 6:44 ` [PATCH v2] " Horia Geantă
2017-04-28 10:31 ` Greg KH
2017-04-28 10:47 ` Horia Geantă
2017-04-28 12:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421120018.22232-1-horia.geanta@nxp.com \
--to=horia.geanta@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiying.wang@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roy.pledge@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).