linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] FS-Cache: print hexadecimal value for special cookies type
@ 2017-04-19 20:38 Jérémy Lefaure
  2017-04-21 19:41 ` Andy Shevchenko
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Jérémy Lefaure @ 2017-04-19 20:38 UTC (permalink / raw)
  To: David Howells; +Cc: linux-cachefs, linux-kernel, Jérémy Lefaure

When building object-list.o, gcc 6 raises a warning on the sprintf call
in fscache_objlist_show:

  CC      fs/fscache/object-list.o
fs/fscache/object-list.c: In function ‘fscache_objlist_show’:
fs/fscache/object-list.c:265:19: warning: ‘sprintf’ may write a
terminating nul past the end of the destination [-Wformat-overflow=]
    sprintf(_type, "%02u", cookie->def->type);
                   ^~~~~~
fs/fscache/object-list.c:265:4: note: ‘sprintf’ output between 3 and 4
bytes into a destination of size 3
    sprintf(_type, "%02u", cookie->def->type);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Moreover, the documentation says that we should have an hex value for
special cookies (see Documentation/filesystems/caching/fscache.txt).

Printing hexadecimal value for special cookies fixes the overflow
warning and complies with the documentation.

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
 fs/fscache/object-list.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fscache/object-list.c b/fs/fscache/object-list.c
index 67f940892ef8..d51303124889 100644
--- a/fs/fscache/object-list.c
+++ b/fs/fscache/object-list.c
@@ -262,7 +262,7 @@ static int fscache_objlist_show(struct seq_file *m, void *v)
 			type = "DT";
 			break;
 		default:
-			sprintf(_type, "%02u", cookie->def->type);
+			sprintf(_type, "%02x", cookie->def->type);
 			type = _type;
 			break;
 		}
-- 
2.12.2

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2017-05-28  0:31 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-19 20:38 [PATCH] FS-Cache: print hexadecimal value for special cookies type Jérémy Lefaure
2017-04-21 19:41 ` Andy Shevchenko
2017-04-21 23:09   ` Jérémy Lefaure
2017-04-24 21:47     ` Andy Shevchenko
2017-04-25 21:37       ` Jérémy Lefaure
2017-04-25 22:04         ` Andy Shevchenko
2017-04-27  0:31 ` [PATCH v2] FS-Cache: fix buffer size for decimal value of special cookie type Jérémy Lefaure
2017-04-27 15:03 ` [PATCH] FS-Cache: print hexadecimal value for special cookies type David Howells
2017-04-27 15:11   ` Jérémy Lefaure
2017-04-27 15:41   ` David Howells
2017-05-28  0:31   ` Jérémy Lefaure

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).