From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1040114AbdDUNsR (ORCPT ); Fri, 21 Apr 2017 09:48:17 -0400 Received: from mail.kernel.org ([198.145.29.136]:49710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1040117AbdDUNsO (ORCPT ); Fri, 21 Apr 2017 09:48:14 -0400 Date: Fri, 21 Apr 2017 22:48:04 +0900 From: Masami Hiramatsu To: Michael Ellerman Cc: "Naveen N. Rao" , Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Ingo Molnar Subject: Re: [PATCH v3 6/7] powerpc: kprobes: emulate instructions on kprobe handler re-entry Message-Id: <20170421224804.4213332fafa6d9fe18868fa1@kernel.org> In-Reply-To: <87lgqv4ni9.fsf@concordia.ellerman.id.au> References: <0d4193a90e4b2ad3cd2ef33d41228b80a2ac9f91.1492604782.git.naveen.n.rao@linux.vnet.ibm.com> <20170419234319.7893df9c158e565fede4a386@kernel.org> <1492620027.h27iuc5j5o.astroid@naverao1-tp.none> <87lgqv4ni9.fsf@concordia.ellerman.id.au> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Apr 2017 16:11:10 +1000 Michael Ellerman wrote: > "Naveen N. Rao" writes: > > > Excerpts from Masami Hiramatsu's message of April 19, 2017 20:13: > >> > >> BTW, as I pointed, 5/7 and 6/7 should be merged since this actually > >> makes meaningful change. > > > > Yes, sorry if I wasn't clear in my previous reply in the (!) previous > > patch series. > > > > Since this has to go through the powerpc tree, I followed this since I > > felt that Michael Ellerman prefers to keep functional changes separate > > from refactoring. I'm fine with either approach. > > > > Michael? > > Yeah I'd definitely like this to be two patches. Otherwise when reading > the combined diff it's much harder to see the change. OK, let it be so. Reviewed-by: Masami Hiramatsu Thanks, -- Masami Hiramatsu