From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425482AbdDVPmX (ORCPT ); Sat, 22 Apr 2017 11:42:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43548 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425420AbdDVPmU (ORCPT ); Sat, 22 Apr 2017 11:42:20 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 12FAAC04B320 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=msnitzer@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 12FAAC04B320 Date: Sat, 22 Apr 2017 11:25:06 -0400 From: Mike Snitzer To: Dan Williams Cc: "linux-nvdimm@lists.01.org" , Toshi Kani , "linux-kernel@vger.kernel.org" , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel , Christoph Hellwig Subject: Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support Message-ID: <20170422152505.GB22651@redhat.com> References: <149245612770.10206.15496018295337908594.stgit@dwillia2-desk3.amr.corp.intel.com> <149245618859.10206.13182319600260215993.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sat, 22 Apr 2017 15:42:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20 2017 at 12:30pm -0400, Dan Williams wrote: > On Mon, Apr 17, 2017 at 12:09 PM, Dan Williams wrote: > > Allocate a dax_device to represent the capacity of a device-mapper > > instance. Provide a ->direct_access() method via the new dax_operations > > indirection that mirrors the functionality of the current direct_access > > support via block_device_operations. Once fs/dax.c has been converted > > to use dax_operations the old dm_blk_direct_access() will be removed. > > > > A new helper dm_dax_get_live_target() is introduced to separate some of > > the dm-specifics from the direct_access implementation. > > > > This enabling is only for the top-level dm representation to upper > > layers. Converting target direct_access implementations is deferred to a > > separate patch. > > > > Cc: Toshi Kani > > Cc: Mike Snitzer > > Hi Mike, > > Any concerns with these dax_device and dax_operations changes to > device-mapper for the upcoming merge window? Sorry for the delay. I just reviewed them, overall looks good. The enabling functions in the DAX code, that are mixed in with the DM changes, could maybe be factored out into separate earlier patches but I don't feel that strongly about that. Feel free to add this tag to the handful of relevant DM patches: Reviewed-by: Mike Snitzer I haven't done a merge with the linux-dm.git 'dm-4.12' branch but it'd be good to verify there aren't any merge conflicts. If there are then it'd be nice to know going in to the merge so that we can forecast as much to Linus. I really appreciate you doing this work! Thanks, Mike