From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425576AbdDVQCK (ORCPT ); Sat, 22 Apr 2017 12:02:10 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:59301 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756808AbdDVQCH (ORCPT ); Sat, 22 Apr 2017 12:02:07 -0400 Date: Sat, 22 Apr 2017 18:02:05 +0200 From: Alexandre Belloni To: Arnd Bergmann Cc: Alessandro Zummo , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Geert Uytterhoeven , Chris Brandt , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: sh: mark PM functions as unused Message-ID: <20170422160205.cwswr7sfjbr4ecl7@piout.net> References: <20170419175346.37122-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170419175346.37122-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/04/2017 at 19:52:43 +0200, Arnd Bergmann wrote: > The sh_rtc_set_irq_wake() function is only called from the suspend/resume handlers > that may be hidden, causing a harmless warning: > > drivers/rtc/rtc-sh.c:724:13: error: 'sh_rtc_set_irq_wake' defined but not used [-Werror=unused-function] > static void sh_rtc_set_irq_wake(struct device *dev, int enabled) > > The most reliable way to avoid the warning is to remove the existing #ifdef > and mark the two functions as __maybe_unused so the compiler can silently > drop all three when there is no reference. > > Fixes: dab5aec64bf5 ("rtc: sh: add support for rza series") > Signed-off-by: Arnd Bergmann > --- > drivers/rtc/rtc-sh.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com