linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Add support for cros-ec-extcon driver
@ 2017-03-01 11:19 Enric Balletbo i Serra
  2017-03-01 11:19 ` [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out Enric Balletbo i Serra
  2017-03-01 11:19 ` [PATCH v2 2/2] dt-bindings: extcon: Add support for cros-ec device Enric Balletbo i Serra
  0 siblings, 2 replies; 18+ messages in thread
From: Enric Balletbo i Serra @ 2017-03-01 11:19 UTC (permalink / raw)
  To: MyungJoo Ham, Rob Herring, Chanwoo Choi
  Cc: Lee Jones, linux-kernel, devicetree

Dear all,

Now that the drm/rockchip landed it's time to review the extcon cros-ec driver. The
cdn-dp driver uses this extcon driver to get cable status and the presence of display
out.

This driver is based on the one available in chromeos-4.4 kernel but removing
all the USB switch role stuff, as this depends on other infrastructures like 
the dwc3 role switch and the Type-C connector.

Note that these patches depends on the following patches to build.

[1] https://lkml.org/lkml/2017/2/14/655

The above patches have been acked and hopefully merged soon in linux-next.

Changes since v1:

 Requested by Chanwoo Choi
 - Rename files changing _ for -
 - Remove the unneeded blank line on bottom of header.
 - Remove kobject.h and cros_ec_commands.h includes.
 - Remove the debug message as is not necessary.
 - Use the tab for indentation instead of space for if sentence.
 - Define each variable on different lines when the variables should be
   initialized.
 - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
 - Add one blank line to split out between state and property setting.
 - Add the author information (header and module)

 Requested by Rob Herring
 - Remove the Extcon word in the binding and replace it to describe better the
   h/w.
 - 'google,extcon-cros-ec' renamed to 'google,extcon-usbc-cros-ec' to indicate
   this is USB Type C related.

 Enric Balletbo
 - As Rob suggested to rename the compatible name to something indicating that
   is USB Type C related I also renamed the file names, extcon-cros-ec ->
   extcon-usbc-cros-ec, I think it's more clear.

Benson Leung (2):
  extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  dt-bindings: extcon: Add support for cros-ec device

 .../bindings/extcon/extcon-usbc-cros-ec.txt        |  24 ++
 drivers/extcon/Kconfig                             |   7 +
 drivers/extcon/Makefile                            |   1 +
 drivers/extcon/extcon-usbc-cros-ec.c               | 415 +++++++++++++++++++++
 include/linux/mfd/cros_ec_commands.h               |  75 ++++
 5 files changed, 522 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
 create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c

-- 
2.9.3

^ permalink raw reply	[flat|nested] 18+ messages in thread

* [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-03-01 11:19 [PATCH v2 0/2] Add support for cros-ec-extcon driver Enric Balletbo i Serra
@ 2017-03-01 11:19 ` Enric Balletbo i Serra
  2017-03-02  7:29   ` Chanwoo Choi
  2017-03-14 17:02   ` Lee Jones
  2017-03-01 11:19 ` [PATCH v2 2/2] dt-bindings: extcon: Add support for cros-ec device Enric Balletbo i Serra
  1 sibling, 2 replies; 18+ messages in thread
From: Enric Balletbo i Serra @ 2017-03-01 11:19 UTC (permalink / raw)
  To: MyungJoo Ham, Rob Herring, Chanwoo Choi
  Cc: Lee Jones, linux-kernel, devicetree, Benson Leung

From: Benson Leung <bleung@chromium.org>

This is the driver for the USB Type C cable detection mechanism
built into the ChromeOS Embedded Controller on systems that
have USB Type-C ports.

At present, this allows for the presence of display out, but in
future, it may also be used to notify host and device type cables
and the presence of power.

Signed-off-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes since v1:
 Requested by Chanwoo Choi
 - Rename files changing _ for -
 - Remove the unneeded blank line on bottom of header.
 - Remove kobject.h and cros_ec_commands.h includes.
 - Remove the debug message as is not necessary.
 - Use the tab for indentation instead of space for if sentence.
 - Define each variable on different lines when the variables should be
   initialized.
 - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
 - Add one blank line to split out between state and property setting.
 - Add the author information (header and module)

 Enric Balletbo
 - As Rob suggested to rename the compatible name to something indicating that
   is USB Type C related I also renamed the file names, extcon-cros-ec ->
   extcon-usbc-cros-ec, I think it's more clear.

 drivers/extcon/Kconfig               |   7 +
 drivers/extcon/Makefile              |   1 +
 drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/cros_ec_commands.h |  75 +++++++
 4 files changed, 498 insertions(+)
 create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c

diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index 96bbae5..9e67e68 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -142,4 +142,11 @@ config EXTCON_USB_GPIO
 	  Say Y here to enable GPIO based USB cable detection extcon support.
 	  Used typically if GPIO is used for USB ID pin detection.
 
+config EXTCON_USBC_CROS_EC
+	tristate "ChromeOS Embedded Controller EXTCON support"
+	depends on MFD_CROS_EC
+	help
+	  Say Y here to enable USB Type C cable detection extcon support when
+	  using Chrome OS EC based USB Type-C ports.
+
 endif
diff --git a/drivers/extcon/Makefile b/drivers/extcon/Makefile
index 237ac3f..e4422949 100644
--- a/drivers/extcon/Makefile
+++ b/drivers/extcon/Makefile
@@ -19,3 +19,4 @@ obj-$(CONFIG_EXTCON_QCOM_SPMI_MISC) += extcon-qcom-spmi-misc.o
 obj-$(CONFIG_EXTCON_RT8973A)	+= extcon-rt8973a.o
 obj-$(CONFIG_EXTCON_SM5502)	+= extcon-sm5502.o
 obj-$(CONFIG_EXTCON_USB_GPIO)	+= extcon-usb-gpio.o
+obj-$(CONFIG_EXTCON_USBC_CROS_EC) += extcon-usbc-cros-ec.o
diff --git a/drivers/extcon/extcon-usbc-cros-ec.c b/drivers/extcon/extcon-usbc-cros-ec.c
new file mode 100644
index 0000000..e759ed4
--- /dev/null
+++ b/drivers/extcon/extcon-usbc-cros-ec.c
@@ -0,0 +1,415 @@
+/**
+ * drivers/extcon/extcon-usbc-cros-ec - ChromeOS Embedded Controller extcon
+ *
+ * Copyright (C) 2017 Google, Inc
+ * Author: Benson Leung <bleung@chromium.org>
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <linux/extcon.h>
+#include <linux/kernel.h>
+#include <linux/mfd/cros_ec.h>
+#include <linux/module.h>
+#include <linux/notifier.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+#include <linux/sched.h>
+
+struct cros_ec_extcon_info {
+	struct device *dev;
+	struct extcon_dev *edev;
+
+	int port_id;
+
+	struct cros_ec_device *ec;
+
+	struct notifier_block notifier;
+
+	bool dp; /* DisplayPort enabled */
+	bool mux; /* SuperSpeed (usb3) enabled */
+	unsigned int power_type;
+};
+
+static const unsigned int usb_type_c_cable[] = {
+	EXTCON_DISP_DP,
+	EXTCON_NONE,
+};
+
+/**
+ * cros_ec_pd_command() - Send a command to the EC.
+ * @info: pointer to struct cros_ec_extcon_info
+ * @command: EC command
+ * @version: EC command version
+ * @outdata: EC command output data
+ * @outsize: Size of outdata
+ * @indata: EC command input data
+ * @insize: Size of indata
+ *
+ * Return: 0 on success, <0 on failure.
+ */
+static int cros_ec_pd_command(struct cros_ec_extcon_info *info,
+			      unsigned int command,
+			      unsigned int version,
+			      void *outdata,
+			      unsigned int outsize,
+			      void *indata,
+			      unsigned int insize)
+{
+	struct cros_ec_command *msg;
+	int ret;
+
+	msg = kzalloc(sizeof(*msg) + max(outsize, insize), GFP_KERNEL);
+
+	msg->version = version;
+	msg->command = command;
+	msg->outsize = outsize;
+	msg->insize = insize;
+
+	if (outsize)
+		memcpy(msg->data, outdata, outsize);
+
+	ret = cros_ec_cmd_xfer_status(info->ec, msg);
+	if (ret >= 0 && insize)
+		memcpy(indata, msg->data, insize);
+
+	kfree(msg);
+	return ret;
+}
+
+/**
+ * cros_ec_usb_get_power_type() - Get power type info about PD device attached
+ * to given port.
+ * @info: pointer to struct cros_ec_extcon_info
+ *
+ * Return: power type on success, <0 on failure.
+ */
+static int cros_ec_usb_get_power_type(struct cros_ec_extcon_info *info)
+{
+	struct ec_params_usb_pd_power_info req;
+	struct ec_response_usb_pd_power_info resp;
+	int ret;
+
+	req.port = info->port_id;
+	ret = cros_ec_pd_command(info, EC_CMD_USB_PD_POWER_INFO, 0,
+				 &req, sizeof(req), &resp, sizeof(resp));
+	if (ret < 0)
+		return ret;
+
+	return resp.type;
+}
+
+/**
+ * cros_ec_usb_get_pd_mux_state() - Get PD mux state for given port.
+ * @info: pointer to struct cros_ec_extcon_info
+ *
+ * Return: PD mux state on success, <0 on failure.
+ */
+static int cros_ec_usb_get_pd_mux_state(struct cros_ec_extcon_info *info)
+{
+	struct ec_params_usb_pd_mux_info req;
+	struct ec_response_usb_pd_mux_info resp;
+	int ret;
+
+	req.port = info->port_id;
+	ret = cros_ec_pd_command(info, EC_CMD_USB_PD_MUX_INFO, 0,
+				 &req, sizeof(req),
+				 &resp, sizeof(resp));
+	if (ret < 0)
+		return ret;
+
+	return resp.flags;
+}
+
+/**
+ * cros_ec_usb_get_role() - Get role info about possible PD device attached to a
+ * given port.
+ * @info: pointer to struct cros_ec_extcon_info
+ * @polarity: pointer to cable polarity (return value)
+ *
+ * Return: role info on success, -ENOTCONN if no cable is connected, <0 on
+ * failure.
+ */
+static int cros_ec_usb_get_role(struct cros_ec_extcon_info *info,
+				bool *polarity)
+{
+	struct ec_params_usb_pd_control pd_control;
+	struct ec_response_usb_pd_control_v1 resp;
+	int ret;
+
+	pd_control.port = info->port_id;
+	pd_control.role = USB_PD_CTRL_ROLE_NO_CHANGE;
+	pd_control.mux = USB_PD_CTRL_MUX_NO_CHANGE;
+	ret = cros_ec_pd_command(info, EC_CMD_USB_PD_CONTROL, 1,
+				 &pd_control, sizeof(pd_control),
+				 &resp, sizeof(resp));
+	if (ret < 0)
+		return ret;
+
+	if (!(resp.enabled & PD_CTRL_RESP_ENABLED_CONNECTED))
+		return -ENOTCONN;
+
+	*polarity = resp.polarity;
+
+	return resp.role;
+}
+
+/**
+ * cros_ec_pd_get_num_ports() - Get number of EC charge ports.
+ * @info: pointer to struct cros_ec_extcon_info
+ *
+ * Return: number of ports on success, <0 on failure.
+ */
+static int cros_ec_pd_get_num_ports(struct cros_ec_extcon_info *info)
+{
+	struct ec_response_usb_pd_ports resp;
+	int ret;
+
+	ret = cros_ec_pd_command(info, EC_CMD_USB_PD_PORTS,
+				 0, NULL, 0, &resp, sizeof(resp));
+	if (ret < 0)
+		return ret;
+
+	return resp.num_ports;
+}
+
+static int extcon_cros_ec_detect_cable(struct cros_ec_extcon_info *info,
+				       bool force)
+{
+	struct device *dev = info->dev;
+	int role, power_type;
+	bool polarity = false;
+	bool dp = false;
+	bool mux = false;
+	bool hpd = false;
+
+	power_type = cros_ec_usb_get_power_type(info);
+	if (power_type < 0) {
+		dev_err(dev, "failed getting power type err = %d\n",
+			power_type);
+		return power_type;
+	}
+
+	role = cros_ec_usb_get_role(info, &polarity);
+	if (role < 0) {
+		if (role != -ENOTCONN) {
+			dev_err(dev, "failed getting role err = %d\n", role);
+			return role;
+		}
+	} else {
+		int pd_mux_state;
+
+		pd_mux_state = cros_ec_usb_get_pd_mux_state(info);
+		if (pd_mux_state < 0)
+			pd_mux_state = USB_PD_MUX_USB_ENABLED;
+
+		dp = pd_mux_state & USB_PD_MUX_DP_ENABLED;
+		mux = pd_mux_state & USB_PD_MUX_USB_ENABLED;
+		hpd = pd_mux_state & USB_PD_MUX_HPD_IRQ;
+	}
+
+	if (force || info->dp != dp || info->mux != mux ||
+		info->power_type != power_type) {
+
+		info->dp = dp;
+		info->mux = mux;
+		info->power_type = power_type;
+
+		extcon_set_state(info->edev, EXTCON_DISP_DP, dp);
+
+		extcon_set_property(info->edev, EXTCON_DISP_DP,
+				    EXTCON_PROP_USB_TYPEC_POLARITY,
+				    (union extcon_property_value)(int)polarity);
+		extcon_set_property(info->edev, EXTCON_DISP_DP,
+				    EXTCON_PROP_USB_SS,
+				    (union extcon_property_value)(int)mux);
+		extcon_set_property(info->edev, EXTCON_DISP_DP,
+				    EXTCON_PROP_DISP_HPD,
+				    (union extcon_property_value)(int)hpd);
+
+		extcon_sync(info->edev, EXTCON_DISP_DP);
+
+	} else if (hpd) {
+		extcon_set_property(info->edev, EXTCON_DISP_DP,
+				    EXTCON_PROP_DISP_HPD,
+				    (union extcon_property_value)(int)hpd);
+		extcon_sync(info->edev, EXTCON_DISP_DP);
+	}
+
+	return 0;
+}
+
+static int extcon_cros_ec_event(struct notifier_block *nb,
+				unsigned long queued_during_suspend,
+				void *_notify)
+{
+	struct cros_ec_extcon_info *info;
+	struct cros_ec_device *ec;
+	u32 host_event;
+
+	info = container_of(nb, struct cros_ec_extcon_info, notifier);
+	ec = info->ec;
+
+	host_event = cros_ec_get_host_event(ec);
+	if (host_event & (EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |
+			  EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX))) {
+		extcon_cros_ec_detect_cable(info, false);
+		return NOTIFY_OK;
+	}
+
+	return NOTIFY_DONE;
+}
+
+static int extcon_cros_ec_probe(struct platform_device *pdev)
+{
+	struct cros_ec_extcon_info *info;
+	struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent);
+	struct device *dev = &pdev->dev;
+	struct device_node *np = dev->of_node;
+	int numports, ret;
+
+	info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL);
+	if (!info)
+		return -ENOMEM;
+
+	info->dev = dev;
+	info->ec = ec;
+
+	if (np) {
+		u32 port;
+
+		ret = of_property_read_u32(np, "google,usb-port-id", &port);
+		if (ret < 0) {
+			dev_err(dev, "Missing google,usb-port-id property\n");
+			return ret;
+		}
+		info->port_id = port;
+	} else {
+		info->port_id = pdev->id;
+	}
+
+	numports = cros_ec_pd_get_num_ports(info);
+	if (numports < 0) {
+		dev_err(dev, "failed getting number of ports! ret = %d\n",
+			numports);
+		return numports;
+	}
+
+	if (info->port_id >= numports) {
+		dev_err(dev, "This system only supports %d ports\n", numports);
+		return -ENODEV;
+	}
+
+	info->edev = devm_extcon_dev_allocate(dev, usb_type_c_cable);
+	if (IS_ERR(info->edev)) {
+		dev_err(dev, "failed to allocate extcon device\n");
+		return -ENOMEM;
+	}
+
+	ret = devm_extcon_dev_register(dev, info->edev);
+	if (ret < 0) {
+		dev_err(dev, "failed to register extcon device\n");
+		return ret;
+	}
+
+	extcon_set_property_capability(info->edev, EXTCON_DISP_DP,
+				       EXTCON_PROP_USB_TYPEC_POLARITY);
+	extcon_set_property_capability(info->edev, EXTCON_DISP_DP,
+				       EXTCON_PROP_USB_SS);
+	extcon_set_property_capability(info->edev, EXTCON_DISP_DP,
+				       EXTCON_PROP_DISP_HPD);
+
+	platform_set_drvdata(pdev, info);
+
+	/* Get PD events from the EC */
+	info->notifier.notifier_call = extcon_cros_ec_event;
+	ret = blocking_notifier_chain_register(&info->ec->event_notifier,
+					       &info->notifier);
+	if (ret < 0) {
+		dev_err(dev, "failed to register notifier\n");
+		return ret;
+	}
+
+	/* Perform initial detection */
+	ret = extcon_cros_ec_detect_cable(info, true);
+	if (ret < 0) {
+		dev_err(dev, "failed to detect initial cable state\n");
+		goto unregister_notifier;
+	}
+
+	return 0;
+
+unregister_notifier:
+	blocking_notifier_chain_unregister(&info->ec->event_notifier,
+					   &info->notifier);
+	return ret;
+}
+
+static int extcon_cros_ec_remove(struct platform_device *pdev)
+{
+	struct cros_ec_extcon_info *info = platform_get_drvdata(pdev);
+
+	blocking_notifier_chain_unregister(&info->ec->event_notifier,
+					   &info->notifier);
+
+	return 0;
+}
+
+#ifdef CONFIG_PM_SLEEP
+static int extcon_cros_ec_suspend(struct device *dev)
+{
+	return 0;
+}
+
+static int extcon_cros_ec_resume(struct device *dev)
+{
+	int ret;
+	struct cros_ec_extcon_info *info = dev_get_drvdata(dev);
+
+	ret = extcon_cros_ec_detect_cable(info, true);
+	if (ret < 0)
+		dev_err(dev, "failed to detect cable state on resume\n");
+
+	return 0;
+}
+
+static const struct dev_pm_ops extcon_cros_ec_dev_pm_ops = {
+	SET_SYSTEM_SLEEP_PM_OPS(extcon_cros_ec_suspend, extcon_cros_ec_resume)
+};
+
+#define DEV_PM_OPS	(&extcon_cros_ec_dev_pm_ops)
+#else
+#define DEV_PM_OPS	NULL
+#endif /* CONFIG_PM_SLEEP */
+
+#ifdef CONFIG_OF
+static const struct of_device_id extcon_cros_ec_of_match[] = {
+	{ .compatible = "google,extcon-usbc-cros-ec" },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, extcon_cros_ec_of_match);
+#endif /* CONFIG_OF */
+
+static struct platform_driver extcon_cros_ec_driver = {
+	.driver = {
+		.name  = "extcon-usbc-cros-ec",
+		.of_match_table = of_match_ptr(extcon_cros_ec_of_match),
+		.pm = DEV_PM_OPS,
+	},
+	.remove  = extcon_cros_ec_remove,
+	.probe   = extcon_cros_ec_probe,
+};
+
+module_platform_driver(extcon_cros_ec_driver);
+
+MODULE_DESCRIPTION("ChromeOS Embedded Controller extcon driver");
+MODULE_AUTHOR("Benson Leung <bleung@chromium.org>");
+MODULE_LICENSE("GPL");
diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
index 255d14a..3ca9953 100644
--- a/include/linux/mfd/cros_ec_commands.h
+++ b/include/linux/mfd/cros_ec_commands.h
@@ -285,10 +285,15 @@ enum host_event_code {
 	EC_HOST_EVENT_HANG_DETECT = 20,
 	/* Hang detect logic detected a hang and warm rebooted the AP */
 	EC_HOST_EVENT_HANG_REBOOT = 21,
+	/* PD MCU triggering host event */
+	EC_HOST_EVENT_PD_MCU = 22,
 
 	/* EC RTC event occurred */
 	EC_HOST_EVENT_RTC = 26,
 
+	/* EC desires to change state of host-controlled USB mux */
+	EC_HOST_EVENT_USB_MUX = 28,
+
 	/*
 	 * The high bit of the event mask is not used as a host event code.  If
 	 * it reads back as set, then the entire event mask should be
@@ -2873,6 +2878,76 @@ struct ec_params_usb_pd_control {
 	uint8_t mux;
 } __packed;
 
+#define PD_CTRL_RESP_ENABLED_COMMS      (1 << 0) /* Communication enabled */
+#define PD_CTRL_RESP_ENABLED_CONNECTED  (1 << 1) /* Device connected */
+#define PD_CTRL_RESP_ENABLED_PD_CAPABLE (1 << 2) /* Partner is PD capable */
+
+struct ec_response_usb_pd_control_v1 {
+	uint8_t enabled;
+	uint8_t role;
+	uint8_t polarity;
+	char state[32];
+} __packed;
+
+#define EC_CMD_USB_PD_PORTS 0x102
+
+struct ec_response_usb_pd_ports {
+	uint8_t num_ports;
+} __packed;
+
+#define EC_CMD_USB_PD_POWER_INFO 0x103
+
+#define PD_POWER_CHARGING_PORT 0xff
+struct ec_params_usb_pd_power_info {
+	uint8_t port;
+} __packed;
+
+enum usb_chg_type {
+	USB_CHG_TYPE_NONE,
+	USB_CHG_TYPE_PD,
+	USB_CHG_TYPE_C,
+	USB_CHG_TYPE_PROPRIETARY,
+	USB_CHG_TYPE_BC12_DCP,
+	USB_CHG_TYPE_BC12_CDP,
+	USB_CHG_TYPE_BC12_SDP,
+	USB_CHG_TYPE_OTHER,
+	USB_CHG_TYPE_VBUS,
+	USB_CHG_TYPE_UNKNOWN,
+};
+
+struct usb_chg_measures {
+	uint16_t voltage_max;
+	uint16_t voltage_now;
+	uint16_t current_max;
+	uint16_t current_lim;
+} __packed;
+
+struct ec_response_usb_pd_power_info {
+	uint8_t role;
+	uint8_t type;
+	uint8_t dualrole;
+	uint8_t reserved1;
+	struct usb_chg_measures meas;
+	uint32_t max_power;
+} __packed;
+
+/* Get info about USB-C SS muxes */
+#define EC_CMD_USB_PD_MUX_INFO 0x11a
+
+struct ec_params_usb_pd_mux_info {
+	uint8_t port; /* USB-C port number */
+} __packed;
+
+/* Flags representing mux state */
+#define USB_PD_MUX_USB_ENABLED       (1 << 0)
+#define USB_PD_MUX_DP_ENABLED        (1 << 1)
+#define USB_PD_MUX_POLARITY_INVERTED (1 << 2)
+#define USB_PD_MUX_HPD_IRQ           (1 << 3)
+
+struct ec_response_usb_pd_mux_info {
+	uint8_t flags; /* USB_PD_MUX_*-encoded USB mux state */
+} __packed;
+
 /*****************************************************************************/
 /*
  * Passthru commands
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* [PATCH v2 2/2] dt-bindings: extcon: Add support for cros-ec device
  2017-03-01 11:19 [PATCH v2 0/2] Add support for cros-ec-extcon driver Enric Balletbo i Serra
  2017-03-01 11:19 ` [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out Enric Balletbo i Serra
@ 2017-03-01 11:19 ` Enric Balletbo i Serra
  2017-03-03  6:43   ` Rob Herring
  1 sibling, 1 reply; 18+ messages in thread
From: Enric Balletbo i Serra @ 2017-03-01 11:19 UTC (permalink / raw)
  To: MyungJoo Ham, Rob Herring, Chanwoo Choi
  Cc: Lee Jones, linux-kernel, devicetree, Benson Leung

From: Benson Leung <bleung@chromium.org>

This patch add documentation for binding of USB Type C cable detection
mechanism is using EXTCON subsystem. The device can detect the presence
of display out but it may also detect other external accessories when
external accessories is attached or detached.

Signed-off-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 - Added Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
 Requested by Rob Herring
 - Remove the Extcon word in the binding and replace it to describe better the
   h/w.
 - 'google,extcon-cros-ec' renamed to 'google,extcon-usbc-cros-ec' to indicate
   this is USB Type C related.

 .../bindings/extcon/extcon-usbc-cros-ec.txt        | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt

diff --git a/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
new file mode 100644
index 0000000..8e8625c
--- /dev/null
+++ b/Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt
@@ -0,0 +1,24 @@
+ChromeOS EC USB Type-C cable and accessories detection
+
+On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
+able to detect the state of external accessories such as display adapters
+or USB devices when said accessories are attached or detached.
+
+The node for this device must be under a cros-ec node like google,cros-ec-spi
+or google,cros-ec-i2c.
+
+Required properties:
+- compatible:		Should be "google,extcon-usbc-cros-ec".
+- google,usb-port-id:	Specifies the USB port ID to use.
+
+Example:
+	cros-ec@0 {
+		compatible = "google,cros-ec-i2c";
+
+		...
+
+		extcon {
+			compatible = "google,extcon-usbc-cros-ec";
+			google,usb-port-id = <0>;
+		};
+	}
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-03-01 11:19 ` [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out Enric Balletbo i Serra
@ 2017-03-02  7:29   ` Chanwoo Choi
  2017-04-05  1:21     ` Chanwoo Choi
  2017-03-14 17:02   ` Lee Jones
  1 sibling, 1 reply; 18+ messages in thread
From: Chanwoo Choi @ 2017-03-02  7:29 UTC (permalink / raw)
  To: Enric Balletbo i Serra, MyungJoo Ham, Rob Herring
  Cc: Lee Jones, linux-kernel, devicetree, Benson Leung

Hi,

On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote:
> From: Benson Leung <bleung@chromium.org>
> 
> This is the driver for the USB Type C cable detection mechanism
> built into the ChromeOS Embedded Controller on systems that
> have USB Type-C ports.
> 
> At present, this allows for the presence of display out, but in
> future, it may also be used to notify host and device type cables
> and the presence of power.
> 
> Signed-off-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> Changes since v1:
>  Requested by Chanwoo Choi
>  - Rename files changing _ for -
>  - Remove the unneeded blank line on bottom of header.
>  - Remove kobject.h and cros_ec_commands.h includes.
>  - Remove the debug message as is not necessary.
>  - Use the tab for indentation instead of space for if sentence.
>  - Define each variable on different lines when the variables should be
>    initialized.
>  - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
>  - Add one blank line to split out between state and property setting.
>  - Add the author information (header and module)
> 
>  Enric Balletbo
>  - As Rob suggested to rename the compatible name to something indicating that
>    is USB Type C related I also renamed the file names, extcon-cros-ec ->
>    extcon-usbc-cros-ec, I think it's more clear.
> 
>  drivers/extcon/Kconfig               |   7 +
>  drivers/extcon/Makefile              |   1 +
>  drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
>  include/linux/mfd/cros_ec_commands.h |  75 +++++++
>  4 files changed, 498 insertions(+)
>  create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
> 

Looks good to me.
Acked-by: Chanwoo Choi <cw00.chio@samsung.com>

I think this patch should be handled with patches[1].
[1] https://lkml.org/lkml/2017/2/14/655

I think that one maintainer among following subsystems
(mfd, chrome h/w platform, rtc and extcon)
will apply their git repository, and then one maintainer
will send the pull request of immutable branch for these patches.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 2/2] dt-bindings: extcon: Add support for cros-ec device
  2017-03-01 11:19 ` [PATCH v2 2/2] dt-bindings: extcon: Add support for cros-ec device Enric Balletbo i Serra
@ 2017-03-03  6:43   ` Rob Herring
  0 siblings, 0 replies; 18+ messages in thread
From: Rob Herring @ 2017-03-03  6:43 UTC (permalink / raw)
  To: Enric Balletbo i Serra
  Cc: MyungJoo Ham, Chanwoo Choi, Lee Jones, linux-kernel, devicetree,
	Benson Leung

On Wed, Mar 01, 2017 at 12:19:43PM +0100, Enric Balletbo i Serra wrote:
> From: Benson Leung <bleung@chromium.org>
> 
> This patch add documentation for binding of USB Type C cable detection
> mechanism is using EXTCON subsystem. The device can detect the presence
> of display out but it may also detect other external accessories when
> external accessories is attached or detached.
> 
> Signed-off-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  - Added Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>  Requested by Rob Herring
>  - Remove the Extcon word in the binding and replace it to describe better the
>    h/w.
>  - 'google,extcon-cros-ec' renamed to 'google,extcon-usbc-cros-ec' to indicate
>    this is USB Type C related.
> 
>  .../bindings/extcon/extcon-usbc-cros-ec.txt        | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/extcon/extcon-usbc-cros-ec.txt

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-03-01 11:19 ` [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out Enric Balletbo i Serra
  2017-03-02  7:29   ` Chanwoo Choi
@ 2017-03-14 17:02   ` Lee Jones
  1 sibling, 0 replies; 18+ messages in thread
From: Lee Jones @ 2017-03-14 17:02 UTC (permalink / raw)
  To: Enric Balletbo i Serra
  Cc: MyungJoo Ham, Rob Herring, Chanwoo Choi, linux-kernel,
	devicetree, Benson Leung

On Wed, 01 Mar 2017, Enric Balletbo i Serra wrote:

> From: Benson Leung <bleung@chromium.org>
> 
> This is the driver for the USB Type C cable detection mechanism
> built into the ChromeOS Embedded Controller on systems that
> have USB Type-C ports.
> 
> At present, this allows for the presence of display out, but in
> future, it may also be used to notify host and device type cables
> and the presence of power.
> 
> Signed-off-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> Changes since v1:
>  Requested by Chanwoo Choi
>  - Rename files changing _ for -
>  - Remove the unneeded blank line on bottom of header.
>  - Remove kobject.h and cros_ec_commands.h includes.
>  - Remove the debug message as is not necessary.
>  - Use the tab for indentation instead of space for if sentence.
>  - Define each variable on different lines when the variables should be
>    initialized.
>  - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
>  - Add one blank line to split out between state and property setting.
>  - Add the author information (header and module)
> 
>  Enric Balletbo
>  - As Rob suggested to rename the compatible name to something indicating that
>    is USB Type C related I also renamed the file names, extcon-cros-ec ->
>    extcon-usbc-cros-ec, I think it's more clear.
> 
>  drivers/extcon/Kconfig               |   7 +
>  drivers/extcon/Makefile              |   1 +
>  drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++

>  include/linux/mfd/cros_ec_commands.h |  75 +++++++

Acked-by: Lee Jones <lee.jones@linaro.org>

>  4 files changed, 498 insertions(+)
>  create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
> 
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index 96bbae5..9e67e68 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -142,4 +142,11 @@ config EXTCON_USB_GPIO
>  	  Say Y here to enable GPIO based USB cable detection extcon support.
>  	  Used typically if GPIO is used for USB ID pin detection.
>  
> +config EXTCON_USBC_CROS_EC
> +	tristate "ChromeOS Embedded Controller EXTCON support"
> +	depends on MFD_CROS_EC
> +	help
> +	  Say Y here to enable USB Type C cable detection extcon support when
> +	  using Chrome OS EC based USB Type-C ports.
> +
>  endif
> diff --git a/drivers/extcon/Makefile b/drivers/extcon/Makefile
> index 237ac3f..e4422949 100644
> --- a/drivers/extcon/Makefile
> +++ b/drivers/extcon/Makefile
> @@ -19,3 +19,4 @@ obj-$(CONFIG_EXTCON_QCOM_SPMI_MISC) += extcon-qcom-spmi-misc.o
>  obj-$(CONFIG_EXTCON_RT8973A)	+= extcon-rt8973a.o
>  obj-$(CONFIG_EXTCON_SM5502)	+= extcon-sm5502.o
>  obj-$(CONFIG_EXTCON_USB_GPIO)	+= extcon-usb-gpio.o
> +obj-$(CONFIG_EXTCON_USBC_CROS_EC) += extcon-usbc-cros-ec.o
> diff --git a/drivers/extcon/extcon-usbc-cros-ec.c b/drivers/extcon/extcon-usbc-cros-ec.c
> new file mode 100644
> index 0000000..e759ed4
> --- /dev/null
> +++ b/drivers/extcon/extcon-usbc-cros-ec.c
> @@ -0,0 +1,415 @@
> +/**
> + * drivers/extcon/extcon-usbc-cros-ec - ChromeOS Embedded Controller extcon
> + *
> + * Copyright (C) 2017 Google, Inc
> + * Author: Benson Leung <bleung@chromium.org>
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <linux/extcon.h>
> +#include <linux/kernel.h>
> +#include <linux/mfd/cros_ec.h>
> +#include <linux/module.h>
> +#include <linux/notifier.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/slab.h>
> +#include <linux/sched.h>
> +
> +struct cros_ec_extcon_info {
> +	struct device *dev;
> +	struct extcon_dev *edev;
> +
> +	int port_id;
> +
> +	struct cros_ec_device *ec;
> +
> +	struct notifier_block notifier;
> +
> +	bool dp; /* DisplayPort enabled */
> +	bool mux; /* SuperSpeed (usb3) enabled */
> +	unsigned int power_type;
> +};
> +
> +static const unsigned int usb_type_c_cable[] = {
> +	EXTCON_DISP_DP,
> +	EXTCON_NONE,
> +};
> +
> +/**
> + * cros_ec_pd_command() - Send a command to the EC.
> + * @info: pointer to struct cros_ec_extcon_info
> + * @command: EC command
> + * @version: EC command version
> + * @outdata: EC command output data
> + * @outsize: Size of outdata
> + * @indata: EC command input data
> + * @insize: Size of indata
> + *
> + * Return: 0 on success, <0 on failure.
> + */
> +static int cros_ec_pd_command(struct cros_ec_extcon_info *info,
> +			      unsigned int command,
> +			      unsigned int version,
> +			      void *outdata,
> +			      unsigned int outsize,
> +			      void *indata,
> +			      unsigned int insize)
> +{
> +	struct cros_ec_command *msg;
> +	int ret;
> +
> +	msg = kzalloc(sizeof(*msg) + max(outsize, insize), GFP_KERNEL);
> +
> +	msg->version = version;
> +	msg->command = command;
> +	msg->outsize = outsize;
> +	msg->insize = insize;
> +
> +	if (outsize)
> +		memcpy(msg->data, outdata, outsize);
> +
> +	ret = cros_ec_cmd_xfer_status(info->ec, msg);
> +	if (ret >= 0 && insize)
> +		memcpy(indata, msg->data, insize);
> +
> +	kfree(msg);
> +	return ret;
> +}
> +
> +/**
> + * cros_ec_usb_get_power_type() - Get power type info about PD device attached
> + * to given port.
> + * @info: pointer to struct cros_ec_extcon_info
> + *
> + * Return: power type on success, <0 on failure.
> + */
> +static int cros_ec_usb_get_power_type(struct cros_ec_extcon_info *info)
> +{
> +	struct ec_params_usb_pd_power_info req;
> +	struct ec_response_usb_pd_power_info resp;
> +	int ret;
> +
> +	req.port = info->port_id;
> +	ret = cros_ec_pd_command(info, EC_CMD_USB_PD_POWER_INFO, 0,
> +				 &req, sizeof(req), &resp, sizeof(resp));
> +	if (ret < 0)
> +		return ret;
> +
> +	return resp.type;
> +}
> +
> +/**
> + * cros_ec_usb_get_pd_mux_state() - Get PD mux state for given port.
> + * @info: pointer to struct cros_ec_extcon_info
> + *
> + * Return: PD mux state on success, <0 on failure.
> + */
> +static int cros_ec_usb_get_pd_mux_state(struct cros_ec_extcon_info *info)
> +{
> +	struct ec_params_usb_pd_mux_info req;
> +	struct ec_response_usb_pd_mux_info resp;
> +	int ret;
> +
> +	req.port = info->port_id;
> +	ret = cros_ec_pd_command(info, EC_CMD_USB_PD_MUX_INFO, 0,
> +				 &req, sizeof(req),
> +				 &resp, sizeof(resp));
> +	if (ret < 0)
> +		return ret;
> +
> +	return resp.flags;
> +}
> +
> +/**
> + * cros_ec_usb_get_role() - Get role info about possible PD device attached to a
> + * given port.
> + * @info: pointer to struct cros_ec_extcon_info
> + * @polarity: pointer to cable polarity (return value)
> + *
> + * Return: role info on success, -ENOTCONN if no cable is connected, <0 on
> + * failure.
> + */
> +static int cros_ec_usb_get_role(struct cros_ec_extcon_info *info,
> +				bool *polarity)
> +{
> +	struct ec_params_usb_pd_control pd_control;
> +	struct ec_response_usb_pd_control_v1 resp;
> +	int ret;
> +
> +	pd_control.port = info->port_id;
> +	pd_control.role = USB_PD_CTRL_ROLE_NO_CHANGE;
> +	pd_control.mux = USB_PD_CTRL_MUX_NO_CHANGE;
> +	ret = cros_ec_pd_command(info, EC_CMD_USB_PD_CONTROL, 1,
> +				 &pd_control, sizeof(pd_control),
> +				 &resp, sizeof(resp));
> +	if (ret < 0)
> +		return ret;
> +
> +	if (!(resp.enabled & PD_CTRL_RESP_ENABLED_CONNECTED))
> +		return -ENOTCONN;
> +
> +	*polarity = resp.polarity;
> +
> +	return resp.role;
> +}
> +
> +/**
> + * cros_ec_pd_get_num_ports() - Get number of EC charge ports.
> + * @info: pointer to struct cros_ec_extcon_info
> + *
> + * Return: number of ports on success, <0 on failure.
> + */
> +static int cros_ec_pd_get_num_ports(struct cros_ec_extcon_info *info)
> +{
> +	struct ec_response_usb_pd_ports resp;
> +	int ret;
> +
> +	ret = cros_ec_pd_command(info, EC_CMD_USB_PD_PORTS,
> +				 0, NULL, 0, &resp, sizeof(resp));
> +	if (ret < 0)
> +		return ret;
> +
> +	return resp.num_ports;
> +}
> +
> +static int extcon_cros_ec_detect_cable(struct cros_ec_extcon_info *info,
> +				       bool force)
> +{
> +	struct device *dev = info->dev;
> +	int role, power_type;
> +	bool polarity = false;
> +	bool dp = false;
> +	bool mux = false;
> +	bool hpd = false;
> +
> +	power_type = cros_ec_usb_get_power_type(info);
> +	if (power_type < 0) {
> +		dev_err(dev, "failed getting power type err = %d\n",
> +			power_type);
> +		return power_type;
> +	}
> +
> +	role = cros_ec_usb_get_role(info, &polarity);
> +	if (role < 0) {
> +		if (role != -ENOTCONN) {
> +			dev_err(dev, "failed getting role err = %d\n", role);
> +			return role;
> +		}
> +	} else {
> +		int pd_mux_state;
> +
> +		pd_mux_state = cros_ec_usb_get_pd_mux_state(info);
> +		if (pd_mux_state < 0)
> +			pd_mux_state = USB_PD_MUX_USB_ENABLED;
> +
> +		dp = pd_mux_state & USB_PD_MUX_DP_ENABLED;
> +		mux = pd_mux_state & USB_PD_MUX_USB_ENABLED;
> +		hpd = pd_mux_state & USB_PD_MUX_HPD_IRQ;
> +	}
> +
> +	if (force || info->dp != dp || info->mux != mux ||
> +		info->power_type != power_type) {
> +
> +		info->dp = dp;
> +		info->mux = mux;
> +		info->power_type = power_type;
> +
> +		extcon_set_state(info->edev, EXTCON_DISP_DP, dp);
> +
> +		extcon_set_property(info->edev, EXTCON_DISP_DP,
> +				    EXTCON_PROP_USB_TYPEC_POLARITY,
> +				    (union extcon_property_value)(int)polarity);
> +		extcon_set_property(info->edev, EXTCON_DISP_DP,
> +				    EXTCON_PROP_USB_SS,
> +				    (union extcon_property_value)(int)mux);
> +		extcon_set_property(info->edev, EXTCON_DISP_DP,
> +				    EXTCON_PROP_DISP_HPD,
> +				    (union extcon_property_value)(int)hpd);
> +
> +		extcon_sync(info->edev, EXTCON_DISP_DP);
> +
> +	} else if (hpd) {
> +		extcon_set_property(info->edev, EXTCON_DISP_DP,
> +				    EXTCON_PROP_DISP_HPD,
> +				    (union extcon_property_value)(int)hpd);
> +		extcon_sync(info->edev, EXTCON_DISP_DP);
> +	}
> +
> +	return 0;
> +}
> +
> +static int extcon_cros_ec_event(struct notifier_block *nb,
> +				unsigned long queued_during_suspend,
> +				void *_notify)
> +{
> +	struct cros_ec_extcon_info *info;
> +	struct cros_ec_device *ec;
> +	u32 host_event;
> +
> +	info = container_of(nb, struct cros_ec_extcon_info, notifier);
> +	ec = info->ec;
> +
> +	host_event = cros_ec_get_host_event(ec);
> +	if (host_event & (EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |
> +			  EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX))) {
> +		extcon_cros_ec_detect_cable(info, false);
> +		return NOTIFY_OK;
> +	}
> +
> +	return NOTIFY_DONE;
> +}
> +
> +static int extcon_cros_ec_probe(struct platform_device *pdev)
> +{
> +	struct cros_ec_extcon_info *info;
> +	struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent);
> +	struct device *dev = &pdev->dev;
> +	struct device_node *np = dev->of_node;
> +	int numports, ret;
> +
> +	info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL);
> +	if (!info)
> +		return -ENOMEM;
> +
> +	info->dev = dev;
> +	info->ec = ec;
> +
> +	if (np) {
> +		u32 port;
> +
> +		ret = of_property_read_u32(np, "google,usb-port-id", &port);
> +		if (ret < 0) {
> +			dev_err(dev, "Missing google,usb-port-id property\n");
> +			return ret;
> +		}
> +		info->port_id = port;
> +	} else {
> +		info->port_id = pdev->id;
> +	}
> +
> +	numports = cros_ec_pd_get_num_ports(info);
> +	if (numports < 0) {
> +		dev_err(dev, "failed getting number of ports! ret = %d\n",
> +			numports);
> +		return numports;
> +	}
> +
> +	if (info->port_id >= numports) {
> +		dev_err(dev, "This system only supports %d ports\n", numports);
> +		return -ENODEV;
> +	}
> +
> +	info->edev = devm_extcon_dev_allocate(dev, usb_type_c_cable);
> +	if (IS_ERR(info->edev)) {
> +		dev_err(dev, "failed to allocate extcon device\n");
> +		return -ENOMEM;
> +	}
> +
> +	ret = devm_extcon_dev_register(dev, info->edev);
> +	if (ret < 0) {
> +		dev_err(dev, "failed to register extcon device\n");
> +		return ret;
> +	}
> +
> +	extcon_set_property_capability(info->edev, EXTCON_DISP_DP,
> +				       EXTCON_PROP_USB_TYPEC_POLARITY);
> +	extcon_set_property_capability(info->edev, EXTCON_DISP_DP,
> +				       EXTCON_PROP_USB_SS);
> +	extcon_set_property_capability(info->edev, EXTCON_DISP_DP,
> +				       EXTCON_PROP_DISP_HPD);
> +
> +	platform_set_drvdata(pdev, info);
> +
> +	/* Get PD events from the EC */
> +	info->notifier.notifier_call = extcon_cros_ec_event;
> +	ret = blocking_notifier_chain_register(&info->ec->event_notifier,
> +					       &info->notifier);
> +	if (ret < 0) {
> +		dev_err(dev, "failed to register notifier\n");
> +		return ret;
> +	}
> +
> +	/* Perform initial detection */
> +	ret = extcon_cros_ec_detect_cable(info, true);
> +	if (ret < 0) {
> +		dev_err(dev, "failed to detect initial cable state\n");
> +		goto unregister_notifier;
> +	}
> +
> +	return 0;
> +
> +unregister_notifier:
> +	blocking_notifier_chain_unregister(&info->ec->event_notifier,
> +					   &info->notifier);
> +	return ret;
> +}
> +
> +static int extcon_cros_ec_remove(struct platform_device *pdev)
> +{
> +	struct cros_ec_extcon_info *info = platform_get_drvdata(pdev);
> +
> +	blocking_notifier_chain_unregister(&info->ec->event_notifier,
> +					   &info->notifier);
> +
> +	return 0;
> +}
> +
> +#ifdef CONFIG_PM_SLEEP
> +static int extcon_cros_ec_suspend(struct device *dev)
> +{
> +	return 0;
> +}
> +
> +static int extcon_cros_ec_resume(struct device *dev)
> +{
> +	int ret;
> +	struct cros_ec_extcon_info *info = dev_get_drvdata(dev);
> +
> +	ret = extcon_cros_ec_detect_cable(info, true);
> +	if (ret < 0)
> +		dev_err(dev, "failed to detect cable state on resume\n");
> +
> +	return 0;
> +}
> +
> +static const struct dev_pm_ops extcon_cros_ec_dev_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(extcon_cros_ec_suspend, extcon_cros_ec_resume)
> +};
> +
> +#define DEV_PM_OPS	(&extcon_cros_ec_dev_pm_ops)
> +#else
> +#define DEV_PM_OPS	NULL
> +#endif /* CONFIG_PM_SLEEP */
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id extcon_cros_ec_of_match[] = {
> +	{ .compatible = "google,extcon-usbc-cros-ec" },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, extcon_cros_ec_of_match);
> +#endif /* CONFIG_OF */
> +
> +static struct platform_driver extcon_cros_ec_driver = {
> +	.driver = {
> +		.name  = "extcon-usbc-cros-ec",
> +		.of_match_table = of_match_ptr(extcon_cros_ec_of_match),
> +		.pm = DEV_PM_OPS,
> +	},
> +	.remove  = extcon_cros_ec_remove,
> +	.probe   = extcon_cros_ec_probe,
> +};
> +
> +module_platform_driver(extcon_cros_ec_driver);
> +
> +MODULE_DESCRIPTION("ChromeOS Embedded Controller extcon driver");
> +MODULE_AUTHOR("Benson Leung <bleung@chromium.org>");
> +MODULE_LICENSE("GPL");
> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
> index 255d14a..3ca9953 100644
> --- a/include/linux/mfd/cros_ec_commands.h
> +++ b/include/linux/mfd/cros_ec_commands.h
> @@ -285,10 +285,15 @@ enum host_event_code {
>  	EC_HOST_EVENT_HANG_DETECT = 20,
>  	/* Hang detect logic detected a hang and warm rebooted the AP */
>  	EC_HOST_EVENT_HANG_REBOOT = 21,
> +	/* PD MCU triggering host event */
> +	EC_HOST_EVENT_PD_MCU = 22,
>  
>  	/* EC RTC event occurred */
>  	EC_HOST_EVENT_RTC = 26,
>  
> +	/* EC desires to change state of host-controlled USB mux */
> +	EC_HOST_EVENT_USB_MUX = 28,
> +
>  	/*
>  	 * The high bit of the event mask is not used as a host event code.  If
>  	 * it reads back as set, then the entire event mask should be
> @@ -2873,6 +2878,76 @@ struct ec_params_usb_pd_control {
>  	uint8_t mux;
>  } __packed;
>  
> +#define PD_CTRL_RESP_ENABLED_COMMS      (1 << 0) /* Communication enabled */
> +#define PD_CTRL_RESP_ENABLED_CONNECTED  (1 << 1) /* Device connected */
> +#define PD_CTRL_RESP_ENABLED_PD_CAPABLE (1 << 2) /* Partner is PD capable */
> +
> +struct ec_response_usb_pd_control_v1 {
> +	uint8_t enabled;
> +	uint8_t role;
> +	uint8_t polarity;
> +	char state[32];
> +} __packed;
> +
> +#define EC_CMD_USB_PD_PORTS 0x102
> +
> +struct ec_response_usb_pd_ports {
> +	uint8_t num_ports;
> +} __packed;
> +
> +#define EC_CMD_USB_PD_POWER_INFO 0x103
> +
> +#define PD_POWER_CHARGING_PORT 0xff
> +struct ec_params_usb_pd_power_info {
> +	uint8_t port;
> +} __packed;
> +
> +enum usb_chg_type {
> +	USB_CHG_TYPE_NONE,
> +	USB_CHG_TYPE_PD,
> +	USB_CHG_TYPE_C,
> +	USB_CHG_TYPE_PROPRIETARY,
> +	USB_CHG_TYPE_BC12_DCP,
> +	USB_CHG_TYPE_BC12_CDP,
> +	USB_CHG_TYPE_BC12_SDP,
> +	USB_CHG_TYPE_OTHER,
> +	USB_CHG_TYPE_VBUS,
> +	USB_CHG_TYPE_UNKNOWN,
> +};
> +
> +struct usb_chg_measures {
> +	uint16_t voltage_max;
> +	uint16_t voltage_now;
> +	uint16_t current_max;
> +	uint16_t current_lim;
> +} __packed;
> +
> +struct ec_response_usb_pd_power_info {
> +	uint8_t role;
> +	uint8_t type;
> +	uint8_t dualrole;
> +	uint8_t reserved1;
> +	struct usb_chg_measures meas;
> +	uint32_t max_power;
> +} __packed;
> +
> +/* Get info about USB-C SS muxes */
> +#define EC_CMD_USB_PD_MUX_INFO 0x11a
> +
> +struct ec_params_usb_pd_mux_info {
> +	uint8_t port; /* USB-C port number */
> +} __packed;
> +
> +/* Flags representing mux state */
> +#define USB_PD_MUX_USB_ENABLED       (1 << 0)
> +#define USB_PD_MUX_DP_ENABLED        (1 << 1)
> +#define USB_PD_MUX_POLARITY_INVERTED (1 << 2)
> +#define USB_PD_MUX_HPD_IRQ           (1 << 3)
> +
> +struct ec_response_usb_pd_mux_info {
> +	uint8_t flags; /* USB_PD_MUX_*-encoded USB mux state */
> +} __packed;
> +
>  /*****************************************************************************/
>  /*
>   * Passthru commands

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-03-02  7:29   ` Chanwoo Choi
@ 2017-04-05  1:21     ` Chanwoo Choi
  2017-04-10 14:52       ` Enric Balletbo i Serra
  2017-04-20 10:16       ` Enric Balletbo i Serra
  0 siblings, 2 replies; 18+ messages in thread
From: Chanwoo Choi @ 2017-04-05  1:21 UTC (permalink / raw)
  To: Enric Balletbo i Serra, MyungJoo Ham, Rob Herring
  Cc: Lee Jones, linux-kernel, devicetree, Benson Leung

Hi Enric,

On 2017년 03월 02일 16:29, Chanwoo Choi wrote:
> Hi,
> 
> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote:
>> From: Benson Leung <bleung@chromium.org>
>>
>> This is the driver for the USB Type C cable detection mechanism
>> built into the ChromeOS Embedded Controller on systems that
>> have USB Type-C ports.
>>
>> At present, this allows for the presence of display out, but in
>> future, it may also be used to notify host and device type cables
>> and the presence of power.
>>
>> Signed-off-by: Benson Leung <bleung@chromium.org>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> ---
>> Changes since v1:
>>  Requested by Chanwoo Choi
>>  - Rename files changing _ for -
>>  - Remove the unneeded blank line on bottom of header.
>>  - Remove kobject.h and cros_ec_commands.h includes.
>>  - Remove the debug message as is not necessary.
>>  - Use the tab for indentation instead of space for if sentence.
>>  - Define each variable on different lines when the variables should be
>>    initialized.
>>  - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
>>  - Add one blank line to split out between state and property setting.
>>  - Add the author information (header and module)
>>
>>  Enric Balletbo
>>  - As Rob suggested to rename the compatible name to something indicating that
>>    is USB Type C related I also renamed the file names, extcon-cros-ec ->
>>    extcon-usbc-cros-ec, I think it's more clear.
>>
>>  drivers/extcon/Kconfig               |   7 +
>>  drivers/extcon/Makefile              |   1 +
>>  drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
>>  include/linux/mfd/cros_ec_commands.h |  75 +++++++
>>  4 files changed, 498 insertions(+)
>>  create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
>>
> 
> Looks good to me.
> Acked-by: Chanwoo Choi <cw00.chio@samsung.com>
> 
> I think this patch should be handled with patches[1].
> [1] https://lkml.org/lkml/2017/2/14/655
> 
> I think that one maintainer among following subsystems
> (mfd, chrome h/w platform, rtc and extcon)
> will apply their git repository, and then one maintainer
> will send the pull request of immutable branch for these patches.
> 

As I mentioned, these patch should be handled with related patches[1].
[1] https://lkml.org/lkml/2017/2/14/655

So, I can't apply these patch on extcon git because there is a merge conflict
and we should handle these patches with immutable branch between subsystem maintainer.

The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1,
please take care of these patches.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-04-05  1:21     ` Chanwoo Choi
@ 2017-04-10 14:52       ` Enric Balletbo i Serra
  2017-04-24 11:58         ` Lee Jones
  2017-04-20 10:16       ` Enric Balletbo i Serra
  1 sibling, 1 reply; 18+ messages in thread
From: Enric Balletbo i Serra @ 2017-04-10 14:52 UTC (permalink / raw)
  To: Chanwoo Choi, MyungJoo Ham, Rob Herring
  Cc: Lee Jones, linux-kernel, devicetree, Benson Leung



On 05/04/17 03:21, Chanwoo Choi wrote:
> Hi Enric,
> 
> On 2017년 03월 02일 16:29, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote:
>>> From: Benson Leung <bleung@chromium.org>
>>>
>>> This is the driver for the USB Type C cable detection mechanism
>>> built into the ChromeOS Embedded Controller on systems that
>>> have USB Type-C ports.
>>>
>>> At present, this allows for the presence of display out, but in
>>> future, it may also be used to notify host and device type cables
>>> and the presence of power.
>>>
>>> Signed-off-by: Benson Leung <bleung@chromium.org>
>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>> ---
>>> Changes since v1:
>>>  Requested by Chanwoo Choi
>>>  - Rename files changing _ for -
>>>  - Remove the unneeded blank line on bottom of header.
>>>  - Remove kobject.h and cros_ec_commands.h includes.
>>>  - Remove the debug message as is not necessary.
>>>  - Use the tab for indentation instead of space for if sentence.
>>>  - Define each variable on different lines when the variables should be
>>>    initialized.
>>>  - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
>>>  - Add one blank line to split out between state and property setting.
>>>  - Add the author information (header and module)
>>>
>>>  Enric Balletbo
>>>  - As Rob suggested to rename the compatible name to something indicating that
>>>    is USB Type C related I also renamed the file names, extcon-cros-ec ->
>>>    extcon-usbc-cros-ec, I think it's more clear.
>>>
>>>  drivers/extcon/Kconfig               |   7 +
>>>  drivers/extcon/Makefile              |   1 +
>>>  drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
>>>  include/linux/mfd/cros_ec_commands.h |  75 +++++++
>>>  4 files changed, 498 insertions(+)
>>>  create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
>>>
>>
>> Looks good to me.
>> Acked-by: Chanwoo Choi <cw00.chio@samsung.com>
>>
>> I think this patch should be handled with patches[1].
>> [1] https://lkml.org/lkml/2017/2/14/655
>>
>> I think that one maintainer among following subsystems
>> (mfd, chrome h/w platform, rtc and extcon)
>> will apply their git repository, and then one maintainer
>> will send the pull request of immutable branch for these patches.
>>
> 
> As I mentioned, these patch should be handled with related patches[1].
> [1] https://lkml.org/lkml/2017/2/14/655
> 
> So, I can't apply these patch on extcon git because there is a merge conflict
> and we should handle these patches with immutable branch between subsystem maintainer.
> 
> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1,
> please take care of these patches.
> 

Thanks, unfortunately the above patch dependency is not merged yet, I'll take
care of these an resend this series rebased again once I have the confirmation
of the above patch is merged or in a immutable branch.

 Enric

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-04-05  1:21     ` Chanwoo Choi
  2017-04-10 14:52       ` Enric Balletbo i Serra
@ 2017-04-20 10:16       ` Enric Balletbo i Serra
  2017-05-23  9:46         ` Chanwoo Choi
  1 sibling, 1 reply; 18+ messages in thread
From: Enric Balletbo i Serra @ 2017-04-20 10:16 UTC (permalink / raw)
  To: Chanwoo Choi, MyungJoo Ham, Rob Herring
  Cc: Lee Jones, linux-kernel, devicetree, Benson Leung, Olof Johansson

On 05/04/17 03:21, Chanwoo Choi wrote:
> Hi Enric,
> 
> On 2017년 03월 02일 16:29, Chanwoo Choi wrote:
>> Hi,
>>
>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote:
>>> From: Benson Leung <bleung@chromium.org>
>>>
>>> This is the driver for the USB Type C cable detection mechanism
>>> built into the ChromeOS Embedded Controller on systems that
>>> have USB Type-C ports.
>>>
>>> At present, this allows for the presence of display out, but in
>>> future, it may also be used to notify host and device type cables
>>> and the presence of power.
>>>
>>> Signed-off-by: Benson Leung <bleung@chromium.org>
>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>> ---
>>> Changes since v1:
>>>  Requested by Chanwoo Choi
>>>  - Rename files changing _ for -
>>>  - Remove the unneeded blank line on bottom of header.
>>>  - Remove kobject.h and cros_ec_commands.h includes.
>>>  - Remove the debug message as is not necessary.
>>>  - Use the tab for indentation instead of space for if sentence.
>>>  - Define each variable on different lines when the variables should be
>>>    initialized.
>>>  - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
>>>  - Add one blank line to split out between state and property setting.
>>>  - Add the author information (header and module)
>>>
>>>  Enric Balletbo
>>>  - As Rob suggested to rename the compatible name to something indicating that
>>>    is USB Type C related I also renamed the file names, extcon-cros-ec ->
>>>    extcon-usbc-cros-ec, I think it's more clear.
>>>
>>>  drivers/extcon/Kconfig               |   7 +
>>>  drivers/extcon/Makefile              |   1 +
>>>  drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
>>>  include/linux/mfd/cros_ec_commands.h |  75 +++++++
>>>  4 files changed, 498 insertions(+)
>>>  create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
>>>
>>
>> Looks good to me.
>> Acked-by: Chanwoo Choi <cw00.chio@samsung.com>
>>
>> I think this patch should be handled with patches[1].
>> [1] https://lkml.org/lkml/2017/2/14/655
>>
>> I think that one maintainer among following subsystems
>> (mfd, chrome h/w platform, rtc and extcon)
>> will apply their git repository, and then one maintainer
>> will send the pull request of immutable branch for these patches.
>>
> 
> As I mentioned, these patch should be handled with related patches[1].
> [1] https://lkml.org/lkml/2017/2/14/655
> 
> So, I can't apply these patch on extcon git because there is a merge conflict
> and we should handle these patches with immutable branch between subsystem maintainer.
> 
> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1,
> please take care of these patches.
> 

CC'ied : Olof Johansson

Olof, Benson,

Could at least the following patch in this series [1] picked as soon as possible
if it's ok.

9630769 New          [01/13] mfd: cros_ec: Add helper for event notifier

This specific patch is blocking this and others like the rtc-cros-ec to land and
the series were send some time ago without received bad feedback.

[1] https://lkml.org/lkml/2017/3/17/321

Many thanks,
 Enric

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-04-10 14:52       ` Enric Balletbo i Serra
@ 2017-04-24 11:58         ` Lee Jones
  0 siblings, 0 replies; 18+ messages in thread
From: Lee Jones @ 2017-04-24 11:58 UTC (permalink / raw)
  To: Enric Balletbo i Serra
  Cc: Chanwoo Choi, MyungJoo Ham, Rob Herring, linux-kernel,
	devicetree, Benson Leung

On Mon, 10 Apr 2017, Enric Balletbo i Serra wrote:

> 
> 
> On 05/04/17 03:21, Chanwoo Choi wrote:
> > Hi Enric,
> > 
> > On 2017년 03월 02일 16:29, Chanwoo Choi wrote:
> >> Hi,
> >>
> >> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote:
> >>> From: Benson Leung <bleung@chromium.org>
> >>>
> >>> This is the driver for the USB Type C cable detection mechanism
> >>> built into the ChromeOS Embedded Controller on systems that
> >>> have USB Type-C ports.
> >>>
> >>> At present, this allows for the presence of display out, but in
> >>> future, it may also be used to notify host and device type cables
> >>> and the presence of power.
> >>>
> >>> Signed-off-by: Benson Leung <bleung@chromium.org>
> >>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >>> ---
> >>> Changes since v1:
> >>>  Requested by Chanwoo Choi
> >>>  - Rename files changing _ for -
> >>>  - Remove the unneeded blank line on bottom of header.
> >>>  - Remove kobject.h and cros_ec_commands.h includes.
> >>>  - Remove the debug message as is not necessary.
> >>>  - Use the tab for indentation instead of space for if sentence.
> >>>  - Define each variable on different lines when the variables should be
> >>>    initialized.
> >>>  - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
> >>>  - Add one blank line to split out between state and property setting.
> >>>  - Add the author information (header and module)
> >>>
> >>>  Enric Balletbo
> >>>  - As Rob suggested to rename the compatible name to something indicating that
> >>>    is USB Type C related I also renamed the file names, extcon-cros-ec ->
> >>>    extcon-usbc-cros-ec, I think it's more clear.
> >>>
> >>>  drivers/extcon/Kconfig               |   7 +
> >>>  drivers/extcon/Makefile              |   1 +
> >>>  drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
> >>>  include/linux/mfd/cros_ec_commands.h |  75 +++++++
> >>>  4 files changed, 498 insertions(+)
> >>>  create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
> >>>
> >>
> >> Looks good to me.
> >> Acked-by: Chanwoo Choi <cw00.chio@samsung.com>
> >>
> >> I think this patch should be handled with patches[1].
> >> [1] https://lkml.org/lkml/2017/2/14/655
> >>
> >> I think that one maintainer among following subsystems
> >> (mfd, chrome h/w platform, rtc and extcon)
> >> will apply their git repository, and then one maintainer
> >> will send the pull request of immutable branch for these patches.
> >>
> > 
> > As I mentioned, these patch should be handled with related patches[1].
> > [1] https://lkml.org/lkml/2017/2/14/655
> > 
> > So, I can't apply these patch on extcon git because there is a merge conflict
> > and we should handle these patches with immutable branch between subsystem maintainer.
> > 
> > The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1,
> > please take care of these patches.
> > 
> 
> Thanks, unfortunately the above patch dependency is not merged yet, I'll take
> care of these an resend this series rebased again once I have the confirmation
> of the above patch is merged or in a immutable branch.

I guess this patch will have to wait until v3.13 now.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-04-20 10:16       ` Enric Balletbo i Serra
@ 2017-05-23  9:46         ` Chanwoo Choi
  2017-05-23  9:52           ` Enric Balletbo i Serra
  0 siblings, 1 reply; 18+ messages in thread
From: Chanwoo Choi @ 2017-05-23  9:46 UTC (permalink / raw)
  To: Enric Balletbo i Serra, MyungJoo Ham, Rob Herring
  Cc: Lee Jones, linux-kernel, devicetree, Benson Leung, Olof Johansson

Hi Enric,

On 2017년 04월 20일 19:16, Enric Balletbo i Serra wrote:
> On 05/04/17 03:21, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2017년 03월 02일 16:29, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote:
>>>> From: Benson Leung <bleung@chromium.org>
>>>>
>>>> This is the driver for the USB Type C cable detection mechanism
>>>> built into the ChromeOS Embedded Controller on systems that
>>>> have USB Type-C ports.
>>>>
>>>> At present, this allows for the presence of display out, but in
>>>> future, it may also be used to notify host and device type cables
>>>> and the presence of power.
>>>>
>>>> Signed-off-by: Benson Leung <bleung@chromium.org>
>>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>>> ---
>>>> Changes since v1:
>>>>  Requested by Chanwoo Choi
>>>>  - Rename files changing _ for -
>>>>  - Remove the unneeded blank line on bottom of header.
>>>>  - Remove kobject.h and cros_ec_commands.h includes.
>>>>  - Remove the debug message as is not necessary.
>>>>  - Use the tab for indentation instead of space for if sentence.
>>>>  - Define each variable on different lines when the variables should be
>>>>    initialized.
>>>>  - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
>>>>  - Add one blank line to split out between state and property setting.
>>>>  - Add the author information (header and module)
>>>>
>>>>  Enric Balletbo
>>>>  - As Rob suggested to rename the compatible name to something indicating that
>>>>    is USB Type C related I also renamed the file names, extcon-cros-ec ->
>>>>    extcon-usbc-cros-ec, I think it's more clear.
>>>>
>>>>  drivers/extcon/Kconfig               |   7 +
>>>>  drivers/extcon/Makefile              |   1 +
>>>>  drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
>>>>  include/linux/mfd/cros_ec_commands.h |  75 +++++++
>>>>  4 files changed, 498 insertions(+)
>>>>  create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
>>>>
>>>
>>> Looks good to me.
>>> Acked-by: Chanwoo Choi <cw00.chio@samsung.com>
>>>
>>> I think this patch should be handled with patches[1].
>>> [1] https://lkml.org/lkml/2017/2/14/655
>>>
>>> I think that one maintainer among following subsystems
>>> (mfd, chrome h/w platform, rtc and extcon)
>>> will apply their git repository, and then one maintainer
>>> will send the pull request of immutable branch for these patches.
>>>
>>
>> As I mentioned, these patch should be handled with related patches[1].
>> [1] https://lkml.org/lkml/2017/2/14/655
>>
>> So, I can't apply these patch on extcon git because there is a merge conflict
>> and we should handle these patches with immutable branch between subsystem maintainer.
>>
>> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1,
>> please take care of these patches.
>>
> 
> CC'ied : Olof Johansson
> 
> Olof, Benson,
> 
> Could at least the following patch in this series [1] picked as soon as possible
> if it's ok.
> 
> 9630769 New          [01/13] mfd: cros_ec: Add helper for event notifier
> 
> This specific patch is blocking this and others like the rtc-cros-ec to land and
> the series were send some time ago without received bad feedback.
> 
> [1] https://lkml.org/lkml/2017/3/17/321
> 
> Many thanks,
>  Enric

Maybe, you better to resend these patches based on v4.12-rcX.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-05-23  9:46         ` Chanwoo Choi
@ 2017-05-23  9:52           ` Enric Balletbo i Serra
  2017-05-23  9:58             ` Chanwoo Choi
  0 siblings, 1 reply; 18+ messages in thread
From: Enric Balletbo i Serra @ 2017-05-23  9:52 UTC (permalink / raw)
  To: Chanwoo Choi, MyungJoo Ham, Rob Herring
  Cc: Lee Jones, linux-kernel, devicetree, Benson Leung, Olof Johansson



On 23/05/17 11:46, Chanwoo Choi wrote:
> Hi Enric,
> 
> On 2017년 04월 20일 19:16, Enric Balletbo i Serra wrote:
>> On 05/04/17 03:21, Chanwoo Choi wrote:
>>> Hi Enric,
>>>
>>> On 2017년 03월 02일 16:29, Chanwoo Choi wrote:
>>>> Hi,
>>>>
>>>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote:
>>>>> From: Benson Leung <bleung@chromium.org>
>>>>>
>>>>> This is the driver for the USB Type C cable detection mechanism
>>>>> built into the ChromeOS Embedded Controller on systems that
>>>>> have USB Type-C ports.
>>>>>
>>>>> At present, this allows for the presence of display out, but in
>>>>> future, it may also be used to notify host and device type cables
>>>>> and the presence of power.
>>>>>
>>>>> Signed-off-by: Benson Leung <bleung@chromium.org>
>>>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>>>> ---
>>>>> Changes since v1:
>>>>>  Requested by Chanwoo Choi
>>>>>  - Rename files changing _ for -
>>>>>  - Remove the unneeded blank line on bottom of header.
>>>>>  - Remove kobject.h and cros_ec_commands.h includes.
>>>>>  - Remove the debug message as is not necessary.
>>>>>  - Use the tab for indentation instead of space for if sentence.
>>>>>  - Define each variable on different lines when the variables should be
>>>>>    initialized.
>>>>>  - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
>>>>>  - Add one blank line to split out between state and property setting.
>>>>>  - Add the author information (header and module)
>>>>>
>>>>>  Enric Balletbo
>>>>>  - As Rob suggested to rename the compatible name to something indicating that
>>>>>    is USB Type C related I also renamed the file names, extcon-cros-ec ->
>>>>>    extcon-usbc-cros-ec, I think it's more clear.
>>>>>
>>>>>  drivers/extcon/Kconfig               |   7 +
>>>>>  drivers/extcon/Makefile              |   1 +
>>>>>  drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
>>>>>  include/linux/mfd/cros_ec_commands.h |  75 +++++++
>>>>>  4 files changed, 498 insertions(+)
>>>>>  create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
>>>>>
>>>>
>>>> Looks good to me.
>>>> Acked-by: Chanwoo Choi <cw00.chio@samsung.com>
>>>>
>>>> I think this patch should be handled with patches[1].
>>>> [1] https://lkml.org/lkml/2017/2/14/655
>>>>
>>>> I think that one maintainer among following subsystems
>>>> (mfd, chrome h/w platform, rtc and extcon)
>>>> will apply their git repository, and then one maintainer
>>>> will send the pull request of immutable branch for these patches.
>>>>
>>>
>>> As I mentioned, these patch should be handled with related patches[1].
>>> [1] https://lkml.org/lkml/2017/2/14/655
>>>
>>> So, I can't apply these patch on extcon git because there is a merge conflict
>>> and we should handle these patches with immutable branch between subsystem maintainer.
>>>
>>> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1,
>>> please take care of these patches.
>>>
>>
>> CC'ied : Olof Johansson
>>
>> Olof, Benson,
>>
>> Could at least the following patch in this series [1] picked as soon as possible
>> if it's ok.
>>
>> 9630769 New          [01/13] mfd: cros_ec: Add helper for event notifier
>>
>> This specific patch is blocking this and others like the rtc-cros-ec to land and
>> the series were send some time ago without received bad feedback.
>>
>> [1] https://lkml.org/lkml/2017/3/17/321
>>
>> Many thanks,
>>  Enric
> 
> Maybe, you better to resend these patches based on v4.12-rcX.
> 

I did a week ago :) The patches were rebased on top of current linux-next,
waiting for the maintainers, hope will be accepted soon so we can unblock this
patch and the rtc patches.

https://lkml.org/lkml/2017/5/16/478

Thanks,
 Enric

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-05-23  9:52           ` Enric Balletbo i Serra
@ 2017-05-23  9:58             ` Chanwoo Choi
  2017-05-23 22:24               ` Benson Leung
  0 siblings, 1 reply; 18+ messages in thread
From: Chanwoo Choi @ 2017-05-23  9:58 UTC (permalink / raw)
  To: Enric Balletbo i Serra, MyungJoo Ham, Rob Herring
  Cc: Lee Jones, linux-kernel, devicetree, Benson Leung, Olof Johansson

Hi,

On 2017년 05월 23일 18:52, Enric Balletbo i Serra wrote:
> 
> 
> On 23/05/17 11:46, Chanwoo Choi wrote:
>> Hi Enric,
>>
>> On 2017년 04월 20일 19:16, Enric Balletbo i Serra wrote:
>>> On 05/04/17 03:21, Chanwoo Choi wrote:
>>>> Hi Enric,
>>>>
>>>> On 2017년 03월 02일 16:29, Chanwoo Choi wrote:
>>>>> Hi,
>>>>>
>>>>> On 2017년 03월 01일 20:19, Enric Balletbo i Serra wrote:
>>>>>> From: Benson Leung <bleung@chromium.org>
>>>>>>
>>>>>> This is the driver for the USB Type C cable detection mechanism
>>>>>> built into the ChromeOS Embedded Controller on systems that
>>>>>> have USB Type-C ports.
>>>>>>
>>>>>> At present, this allows for the presence of display out, but in
>>>>>> future, it may also be used to notify host and device type cables
>>>>>> and the presence of power.
>>>>>>
>>>>>> Signed-off-by: Benson Leung <bleung@chromium.org>
>>>>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>>>>> ---
>>>>>> Changes since v1:
>>>>>>  Requested by Chanwoo Choi
>>>>>>  - Rename files changing _ for -
>>>>>>  - Remove the unneeded blank line on bottom of header.
>>>>>>  - Remove kobject.h and cros_ec_commands.h includes.
>>>>>>  - Remove the debug message as is not necessary.
>>>>>>  - Use the tab for indentation instead of space for if sentence.
>>>>>>  - Define each variable on different lines when the variables should be
>>>>>>    initialized.
>>>>>>  - Remove EXTCON_USB and EXTCON_USB_HOST as are not really used for now.
>>>>>>  - Add one blank line to split out between state and property setting.
>>>>>>  - Add the author information (header and module)
>>>>>>
>>>>>>  Enric Balletbo
>>>>>>  - As Rob suggested to rename the compatible name to something indicating that
>>>>>>    is USB Type C related I also renamed the file names, extcon-cros-ec ->
>>>>>>    extcon-usbc-cros-ec, I think it's more clear.
>>>>>>
>>>>>>  drivers/extcon/Kconfig               |   7 +
>>>>>>  drivers/extcon/Makefile              |   1 +
>>>>>>  drivers/extcon/extcon-usbc-cros-ec.c | 415 +++++++++++++++++++++++++++++++++++
>>>>>>  include/linux/mfd/cros_ec_commands.h |  75 +++++++
>>>>>>  4 files changed, 498 insertions(+)
>>>>>>  create mode 100644 drivers/extcon/extcon-usbc-cros-ec.c
>>>>>>
>>>>>
>>>>> Looks good to me.
>>>>> Acked-by: Chanwoo Choi <cw00.chio@samsung.com>
>>>>>
>>>>> I think this patch should be handled with patches[1].
>>>>> [1] https://lkml.org/lkml/2017/2/14/655
>>>>>
>>>>> I think that one maintainer among following subsystems
>>>>> (mfd, chrome h/w platform, rtc and extcon)
>>>>> will apply their git repository, and then one maintainer
>>>>> will send the pull request of immutable branch for these patches.
>>>>>
>>>>
>>>> As I mentioned, these patch should be handled with related patches[1].
>>>> [1] https://lkml.org/lkml/2017/2/14/655
>>>>
>>>> So, I can't apply these patch on extcon git because there is a merge conflict
>>>> and we should handle these patches with immutable branch between subsystem maintainer.
>>>>
>>>> The v4.11-rc5 was released, if you want to apply this patch to the v4.12-rc1,
>>>> please take care of these patches.
>>>>
>>>
>>> CC'ied : Olof Johansson
>>>
>>> Olof, Benson,
>>>
>>> Could at least the following patch in this series [1] picked as soon as possible
>>> if it's ok.
>>>
>>> 9630769 New          [01/13] mfd: cros_ec: Add helper for event notifier
>>>
>>> This specific patch is blocking this and others like the rtc-cros-ec to land and
>>> the series were send some time ago without received bad feedback.
>>>
>>> [1] https://lkml.org/lkml/2017/3/17/321
>>>
>>> Many thanks,
>>>  Enric
>>
>> Maybe, you better to resend these patches based on v4.12-rcX.
>>
> 
> I did a week ago :) The patches were rebased on top of current linux-next,
> waiting for the maintainers, hope will be accepted soon so we can unblock this
> patch and the rtc patches.
> 
> https://lkml.org/lkml/2017/5/16/478
> 

OK. This patch must need the immutable branch.

I expect that some maintainer will make the immutable branch
and then send pull request to other maintainer related to them.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-05-23  9:58             ` Chanwoo Choi
@ 2017-05-23 22:24               ` Benson Leung
  2017-07-12 10:28                 ` Enric Balletbo Serra
  0 siblings, 1 reply; 18+ messages in thread
From: Benson Leung @ 2017-05-23 22:24 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: Enric Balletbo i Serra, MyungJoo Ham, Rob Herring, Lee Jones,
	linux-kernel, devicetree, Olof Johansson

Hi Chanwoo,


On Tue, May 23, 2017 at 2:58 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:

> OK. This patch must need the immutable branch.
>
> I expect that some maintainer will make the immutable branch
> and then send pull request to other maintainer related to them.
>

I'll create an immutable branch with this this week. Thank you!

Benson

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-05-23 22:24               ` Benson Leung
@ 2017-07-12 10:28                 ` Enric Balletbo Serra
  2017-07-13 10:26                   ` Chanwoo Choi
  0 siblings, 1 reply; 18+ messages in thread
From: Enric Balletbo Serra @ 2017-07-12 10:28 UTC (permalink / raw)
  To: Benson Leung
  Cc: Chanwoo Choi, Enric Balletbo i Serra, MyungJoo Ham, Rob Herring,
	Lee Jones, linux-kernel, devicetree, Olof Johansson,
	Guenter Roeck

Hi Chanwoo,

2017-05-24 0:24 GMT+02:00 Benson Leung <bleung@chromium.org>:
> Hi Chanwoo,
>
>
> On Tue, May 23, 2017 at 2:58 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>
>> OK. This patch must need the immutable branch.
>>
>> I expect that some maintainer will make the immutable branch
>> and then send pull request to other maintainer related to them.
>>
>
> I'll create an immutable branch with this this week. Thank you!
>

The patch that was required for this series [1] is currently merged in
mainline, so I think this can go for the next merge window. Want you I
rebase these patches on top and resend or you want just pick-up these?

Best regards,
 Enric

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/chrome?id=68c35ea25bdd4ad10445c4c02f7d48b3dccab8cc


> Benson
>
> --
> Benson Leung
> Staff Software Engineer
> Chrome OS Kernel
> Google Inc.
> bleung@google.com
> Chromium OS Project
> bleung@chromium.org

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-07-12 10:28                 ` Enric Balletbo Serra
@ 2017-07-13 10:26                   ` Chanwoo Choi
  2017-07-13 10:45                     ` Enric Balletbo Serra
  0 siblings, 1 reply; 18+ messages in thread
From: Chanwoo Choi @ 2017-07-13 10:26 UTC (permalink / raw)
  To: Enric Balletbo Serra, Benson Leung
  Cc: Enric Balletbo i Serra, MyungJoo Ham, Rob Herring, Lee Jones,
	linux-kernel, devicetree, Olof Johansson, Guenter Roeck

Hi Enric,

On 2017년 07월 12일 19:28, Enric Balletbo Serra wrote:
> Hi Chanwoo,
> 
> 2017-05-24 0:24 GMT+02:00 Benson Leung <bleung@chromium.org>:
>> Hi Chanwoo,
>>
>>
>> On Tue, May 23, 2017 at 2:58 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>
>>> OK. This patch must need the immutable branch.
>>>
>>> I expect that some maintainer will make the immutable branch
>>> and then send pull request to other maintainer related to them.
>>>
>>
>> I'll create an immutable branch with this this week. Thank you!
>>
> 
> The patch that was required for this series [1] is currently merged in
> mainline, so I think this can go for the next merge window. Want you I
> rebase these patches on top and resend or you want just pick-up these?

I didn't receive the any mail/info about immutable branch.

It is late to merge this patch to v4.13-rc1. The merge window already opened.
because I sent the extcon's pull request to GregKH for v4.13-rc1.

After releasing the v4.13-rc1, please resend these patches.
I'll apply them on v4.14 queue.

> 
> Best regards,
>  Enric
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/chrome?id=68c35ea25bdd4ad10445c4c02f7d48b3dccab8cc
> 
> 
>> Benson
>>
>> --
>> Benson Leung
>> Staff Software Engineer
>> Chrome OS Kernel
>> Google Inc.
>> bleung@google.com
>> Chromium OS Project
>> bleung@chromium.org
> 
> 
> 


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-07-13 10:26                   ` Chanwoo Choi
@ 2017-07-13 10:45                     ` Enric Balletbo Serra
  2017-07-16  6:01                       ` Chanwoo Choi
  0 siblings, 1 reply; 18+ messages in thread
From: Enric Balletbo Serra @ 2017-07-13 10:45 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: Benson Leung, Enric Balletbo i Serra, MyungJoo Ham, Rob Herring,
	Lee Jones, linux-kernel, devicetree, Olof Johansson,
	Guenter Roeck

2017-07-13 12:26 GMT+02:00 Chanwoo Choi <cw00.choi@samsung.com>:
> Hi Enric,
>
> On 2017년 07월 12일 19:28, Enric Balletbo Serra wrote:
>> Hi Chanwoo,
>>
>> 2017-05-24 0:24 GMT+02:00 Benson Leung <bleung@chromium.org>:
>>> Hi Chanwoo,
>>>
>>>
>>> On Tue, May 23, 2017 at 2:58 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>>
>>>> OK. This patch must need the immutable branch.
>>>>
>>>> I expect that some maintainer will make the immutable branch
>>>> and then send pull request to other maintainer related to them.
>>>>
>>>
>>> I'll create an immutable branch with this this week. Thank you!
>>>
>>
>> The patch that was required for this series [1] is currently merged in
>> mainline, so I think this can go for the next merge window. Want you I
>> rebase these patches on top and resend or you want just pick-up these?
>
> I didn't receive the any mail/info about immutable branch.
>
> It is late to merge this patch to v4.13-rc1. The merge window already opened.
> because I sent the extcon's pull request to GregKH for v4.13-rc1.
>
> After releasing the v4.13-rc1, please resend these patches.
> I'll apply them on v4.14 queue.
>

Perfect, v4.14 it's fine, I'll resend once this merge window closes.

Thanks,
 Enric

>>
>> Best regards,
>>  Enric
>>
>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/chrome?id=68c35ea25bdd4ad10445c4c02f7d48b3dccab8cc
>>
>>
>>> Benson
>>>
>>> --
>>> Benson Leung
>>> Staff Software Engineer
>>> Chrome OS Kernel
>>> Google Inc.
>>> bleung@google.com
>>> Chromium OS Project
>>> bleung@chromium.org
>>
>>
>>
>
>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics

^ permalink raw reply	[flat|nested] 18+ messages in thread

* Re: [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  2017-07-13 10:45                     ` Enric Balletbo Serra
@ 2017-07-16  6:01                       ` Chanwoo Choi
  0 siblings, 0 replies; 18+ messages in thread
From: Chanwoo Choi @ 2017-07-16  6:01 UTC (permalink / raw)
  To: Enric Balletbo Serra
  Cc: Chanwoo Choi, Benson Leung, Enric Balletbo i Serra, MyungJoo Ham,
	Rob Herring, Lee Jones, linux-kernel, devicetree, Olof Johansson,
	Guenter Roeck

Hi Enric,

On Thu, Jul 13, 2017 at 7:45 PM, Enric Balletbo Serra
<eballetbo@gmail.com> wrote:
> 2017-07-13 12:26 GMT+02:00 Chanwoo Choi <cw00.choi@samsung.com>:
>> Hi Enric,
>>
>> On 2017년 07월 12일 19:28, Enric Balletbo Serra wrote:
>>> Hi Chanwoo,
>>>
>>> 2017-05-24 0:24 GMT+02:00 Benson Leung <bleung@chromium.org>:
>>>> Hi Chanwoo,
>>>>
>>>>
>>>> On Tue, May 23, 2017 at 2:58 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>>>>
>>>>> OK. This patch must need the immutable branch.
>>>>>
>>>>> I expect that some maintainer will make the immutable branch
>>>>> and then send pull request to other maintainer related to them.
>>>>>
>>>>
>>>> I'll create an immutable branch with this this week. Thank you!
>>>>
>>>
>>> The patch that was required for this series [1] is currently merged in
>>> mainline, so I think this can go for the next merge window. Want you I
>>> rebase these patches on top and resend or you want just pick-up these?
>>
>> I didn't receive the any mail/info about immutable branch.
>>
>> It is late to merge this patch to v4.13-rc1. The merge window already opened.
>> because I sent the extcon's pull request to GregKH for v4.13-rc1.
>>
>> After releasing the v4.13-rc1, please resend these patches.
>> I'll apply them on v4.14 queue.
>>
>
> Perfect, v4.14 it's fine, I'll resend once this merge window closes.

v4.13-rc1 was released. Please resend these patches and then I'll merge them.

>
> Thanks,
>  Enric
>
>>>
>>> Best regards,
>>>  Enric
>>>
>>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/platform/chrome?id=68c35ea25bdd4ad10445c4c02f7d48b3dccab8cc
>>>
>>>
>>>> Benson
>>>>
>>>> --
>>>> Benson Leung
>>>> Staff Software Engineer
>>>> Chrome OS Kernel
>>>> Google Inc.
>>>> bleung@google.com
>>>> Chromium OS Project
>>>> bleung@chromium.org
>>>
>>>
>>>
>>
>>
>> --
>> Best Regards,
>> Chanwoo Choi
>> Samsung Electronics



-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2017-07-16  6:02 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-01 11:19 [PATCH v2 0/2] Add support for cros-ec-extcon driver Enric Balletbo i Serra
2017-03-01 11:19 ` [PATCH v2 1/2] extcon: cros-ec: Add extcon-cros-ec driver to support display out Enric Balletbo i Serra
2017-03-02  7:29   ` Chanwoo Choi
2017-04-05  1:21     ` Chanwoo Choi
2017-04-10 14:52       ` Enric Balletbo i Serra
2017-04-24 11:58         ` Lee Jones
2017-04-20 10:16       ` Enric Balletbo i Serra
2017-05-23  9:46         ` Chanwoo Choi
2017-05-23  9:52           ` Enric Balletbo i Serra
2017-05-23  9:58             ` Chanwoo Choi
2017-05-23 22:24               ` Benson Leung
2017-07-12 10:28                 ` Enric Balletbo Serra
2017-07-13 10:26                   ` Chanwoo Choi
2017-07-13 10:45                     ` Enric Balletbo Serra
2017-07-16  6:01                       ` Chanwoo Choi
2017-03-14 17:02   ` Lee Jones
2017-03-01 11:19 ` [PATCH v2 2/2] dt-bindings: extcon: Add support for cros-ec device Enric Balletbo i Serra
2017-03-03  6:43   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).