From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,
linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, linux-sunxi@googlegroups.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 13/18] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver
Date: Mon, 24 Apr 2017 14:24:11 +0200 [thread overview]
Message-ID: <20170424122411.GA9349@Red> (raw)
In-Reply-To: <20170412124153.q6zvdvqkroizaxgb@lukather>
On Wed, Apr 12, 2017 at 02:41:53PM +0200, Maxime Ripard wrote:
> On Wed, Apr 12, 2017 at 01:13:55PM +0200, Corentin Labbe wrote:
> > The dwmac-sun8i is an Ethernet MAC that supports 10/100/1000 Mbit
> > connections. It is very similar to the device found in the Allwinner
> > H3, but lacks the internal 100 Mbit PHY and its associated control
> > bits.
> > This adds the necessary bits to the Allwinner A64 SoC .dtsi, but keeps
> > it disabled at this level.
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 37 +++++++++++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index 0b0f4ab..2569827 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -287,6 +287,23 @@
> > bias-pull-up;
> > };
> >
> > + rmii_pins: rmii_pins {
> > + pins = "PD10", "PD11", "PD13", "PD14",
> > + "PD17", "PD18", "PD19", "PD20",
> > + "PD22", "PD23";
>
> Please align the wrapped lines on the first pin.
>
OK
> > + function = "emac";
> > + drive-strength = <40>;
>
> Do you actually need that for all the boards, or only a few of them?
I have tried to use lower value without success on some boards. (opipc/pine64 in my memory)
Regards
Corentin Labbe
next prev parent reply other threads:[~2017-04-24 12:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 11:13 [PATCH v4 00/18] net-next: stmmac: add dwmac-sun8i ethernet driver Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 01/18] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 02/18] net: stmmac: add optional setup function Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 03/18] dt-bindings: net: Add DT bindings documentation for Allwinner dwmac-sun8i Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 04/18] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon Corentin Labbe
2017-04-19 21:06 ` Rob Herring
2017-04-19 23:38 ` André Przywara
2017-04-20 6:50 ` Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 05/18] net-next: stmmac: Add dwmac-sun8i Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 06/18] arm: sun8i: sunxi-h3-h5: Add dt node for the syscon control module Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 07/18] arm: sun8i: sunxi-h3-h5: add dwmac-sun8i ethernet driver Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 08/18] arm: sun8i: orangepi-pc: Enable dwmac-sun8i Corentin Labbe
2017-04-12 12:39 ` Maxime Ripard
2017-04-12 11:13 ` [PATCH v4 09/18] arm: sun8i: orangepi-2: " Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 10/18] arm: sun8i: orangepi-one: " Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 11/18] arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 12/18] arm64: allwinner: sun50i-a64: Add dt node for the syscon control module Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 13/18] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver Corentin Labbe
2017-04-12 12:41 ` Maxime Ripard
2017-04-24 12:24 ` Corentin Labbe [this message]
2017-04-24 12:58 ` Chen-Yu Tsai
2017-04-12 11:13 ` [PATCH v4 14/18] arm: allwinner: pine64: Enable dwmac-sun8i Corentin Labbe
2017-04-12 12:42 ` Maxime Ripard
2017-04-12 11:13 ` [PATCH v4 15/18] arm: allwinner: pine64-plus: " Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 16/18] arm64: allwinner: bananapi-m64: " Corentin Labbe
2017-04-12 11:13 ` [PATCH v4 17/18] arm: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig Corentin Labbe
2017-04-12 11:14 ` [PATCH v4 18/18] arm: multi_v7: Enable dwmac-sun8i driver on multi_v7_defconfig Corentin Labbe
2017-04-12 12:42 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424122411.GA9349@Red \
--to=clabbe.montjoie@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).