From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1171293AbdDXN3I (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Apr 2017 09:29:08 -0400
Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.232]:54852 "EHLO
        cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1171383AbdDXN2k (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Apr 2017 09:28:40 -0400
Date: Mon, 24 Apr 2017 09:28:36 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        Clark Williams <williams@redhat.com>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        John Kacur <jkacur@redhat.com>
Subject: Re: [RFC][PATCH tip/sched/core] sched/rt: Simplify the IPI rt
 balancing logic
Message-ID: <20170424132835.berjg6jakizu5s4v@home.goodmis.org>
References: <20170421224929.1a4bbeec@gandalf.local.home>
 <20170424085154.d6ny6vmbmuaoxiln@hirez.programming.kicks-ass.net>
 <20170424084318.2d03700f@gandalf.local.home>
 <20170424125200.vxfmehm4tpdpeisc@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170424125200.vxfmehm4tpdpeisc@hirez.programming.kicks-ass.net>
User-Agent: NeoMutt/20170113 (1.7.2)
X-RR-Connecting-IP: 107.14.168.6:25
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 24, 2017 at 02:52:00PM +0200, Peter Zijlstra wrote:
> On Mon, Apr 24, 2017 at 08:43:18AM -0400, Steven Rostedt wrote:
> > On Mon, 24 Apr 2017 10:51:54 +0200
> > Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Fri, Apr 21, 2017 at 10:49:29PM -0400, Steven Rostedt wrote:
> > > > When a CPU schedules in a lower priority task and wants to make sure
> > > > overloaded CPUs know about it. It increments the rto_loop_next. Then it does
> > > > an atomic_inc_return() on rto_loop_start. If the returned value is not "1",
> > > > then it does atomic_dec() on rt_loop_start and returns. If the value is "1",
> > > > then it will take the rto_lock to synchronize with a possible IPI being sent
> > > > around to the overloaded CPUs.  
> > > 
> > > > +	start = atomic_inc_return(&rq->rd->rto_loop_start);
> > > > +	if (start != 1)
> > > > +		goto out;  
> > > 
> > > > +out:
> > > > +	atomic_dec(&rq->rd->rto_loop_start);  
> > > 
> > > 
> > > Did you just write a very expensive test-and-set trylock?
> > 
> > Probably. I didn't know we had a generic one. Where is it?
> > 
> 
> There isn't. What I was getting at though is that something like:
> 
> static inline bool rto_start_trylock(atomic_t *v)
> {
> 	int zero = 0;
> 	return atomic_try_cmpxchg(v, &zero, 1);

To keep the same semantics of spin_trylock(), should we:

  return !atomic_cmpxchg(v, &zero, 1);

as the old value of zero means we got it.

BTW, I don't see any atomic_try_cmpxchg().


> }
> 
> static void rto_start_unlock(atomic_t *v)
> {
> 	atomic_set_release(v, 0);
> }
> 
> Is more: clearer, faster and correct.
> 
> 
> Clearer as that it better describes what it does, faster as that you
> only have a single atomic, and more correct because it does a RELEASE in
> the case we care about.
> 

Yes, I like the above. Thanks, I will add.

-- Steve