From: David Miller <davem@davemloft.net>
To: alexandre.belloni@free-electrons.com
Cc: al.kochet@gmail.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sergei.shtylyov@cogentembedded.com, rogerq@ti.com,
madalin.bucur@nxp.com
Subject: Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt
Date: Tue, 25 Apr 2017 16:26:25 -0400 (EDT) [thread overview]
Message-ID: <20170425.162625.941066354018174414.davem@davemloft.net> (raw)
In-Reply-To: <20170425200911.d7zfakqs5k5zwisg@piout.net>
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Date: Tue, 25 Apr 2017 22:09:11 +0200
> Hi,
>
> On 25/04/2017 at 18:25:30 +0300, Alexander Kochetkov wrote:
>> Hello David!
>>
>> > 25 апр. 2017 г., в 17:36, David Miller <davem@davemloft.net> написал(а):
>> >
>> > So... what are we doing here?
>> >
>> > My understanding is that this should fix the same problem that commit
>> > 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto
>> > negotiation on startup") fixed and that this micrel commit should thus
>> > be reverted to improve MAC startup times which regressed.
>> >
>> > Florian, any guidance?
>>
>> Yes, this should be done.
>>
>> I aksed Alexandre to check if 99f81afc139c6edd14d77a91ee91685a414a1c66 ("phy: micrel: Disable auto
>> negotiation on startup») can be reverted, and he answered what it may do that
>> sometime this/next week.
>>
>
> Yes, it can be safely reverted after Alexander's patch. I had to test on
> v4.7 because we are not using interrupts on those boards since v4.8
> (another issue to be fixed).
>
> As Florian pointed out, at the time I sent my patch, I didn't have time
> to investigate whether this was affecting other phys, see
> https://lkml.org/lkml/2016/2/26/766
>
> I can send the revert or you can do it.
I can take care of it, thanks for testing.
next prev parent reply other threads:[~2017-04-25 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 11:00 [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt Alexander Kochetkov
2017-04-20 11:00 ` Alexander Kochetkov
2017-04-20 15:33 ` Alexander Kochetkov
2017-04-21 14:18 ` Roger Quadros
2017-04-21 14:42 ` Alexander Kochetkov
2017-04-25 14:36 ` David Miller
2017-04-25 15:25 ` Alexander Kochetkov
2017-04-25 20:09 ` Alexandre Belloni
2017-04-25 20:26 ` David Miller [this message]
2017-04-25 21:07 ` Florian Fainelli
2017-04-26 10:21 ` Alexandre Belloni
2017-04-26 18:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425.162625.941066354018174414.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=al.kochet@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).