From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: js1304@gmail.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org, kernel-team@lge.com,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH v3 3/4] zram: make deduplication feature optional
Date: Tue, 25 Apr 2017 19:24:40 +0900 [thread overview]
Message-ID: <20170425102440.GA491@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <1492737291-11455-4-git-send-email-iamjoonsoo.kim@lge.com>
Hello,
On (04/21/17 10:14), js1304@gmail.com wrote:
[..]
> int zram_dedup_init(struct zram *zram, size_t num_pages);
> void zram_dedup_fini(struct zram *zram);
> +#else
> +
> +static inline u64 zram_dedup_dup_size(struct zram *zram) { return 0; }
> +static inline u64 zram_dedup_meta_size(struct zram *zram) { return 0; }
> +
> +static inline void zram_dedup_insert(struct zram *zram, struct zram_entry *new,
> + u32 checksum) { }
> +static inline struct zram_entry *zram_dedup_find(struct zram *zram,
> + struct page *page, u32 *checksum) { return NULL; }
> +
> +static inline void zram_dedup_init_entry(struct zram *zram,
> + struct zram_entry *entry, unsigned long handle,
> + unsigned int len) { }
> +static inline bool zram_dedup_put_entry(struct zram *zram,
> + struct zram_entry *entry) { return true; }
> +
> +static inline int zram_dedup_init(struct zram *zram,
> + size_t num_pages) { return 0; }
> +static inline void zram_dedup_fini(struct zram *zram) { }
> +
> +#endif
doesn't compile on CONFIG_ZRAM=m config.
-ss
next prev parent reply other threads:[~2017-04-25 10:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 1:14 [PATCH v3 0/4] zram: implement deduplication in zram js1304
2017-04-21 1:14 ` [PATCH v3 1/4] zram: introduce zram_entry to prepare dedup functionality js1304
2017-04-21 1:14 ` [PATCH v3 2/4] zram: implement deduplication in zram js1304
2017-04-21 1:14 ` [PATCH v3 3/4] zram: make deduplication feature optional js1304
2017-04-25 6:51 ` Minchan Kim
2017-04-25 8:13 ` Joonsoo Kim
2017-04-25 10:24 ` Sergey Senozhatsky [this message]
2017-04-26 0:53 ` Joonsoo Kim
2017-04-21 1:14 ` [PATCH v3 4/4] zram: compare all the entries with same checksum for deduplication js1304
2017-04-25 6:53 ` [PATCH v3 0/4] zram: implement deduplication in zram Minchan Kim
2017-04-25 8:15 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425102440.GA491@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).