From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1946328AbdDYMdW (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Apr 2017 08:33:22 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:41047 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1430451AbdDYMdM (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Apr 2017 08:33:12 -0400
Date: Tue, 25 Apr 2017 15:32:50 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] HSI: omap_ssi: Delete an error message for a failed
 memory allocation in ssi_add_controller()
Message-ID: <20170425123250.ipltfpgcgbtk6h3g@mwanda>
References: <2fa2c33a-dc43-7e03-03d7-7ca04931e6c7@users.sourceforge.net>
 <e6102bce-0b27-68e6-8247-f87851f7f9b9@users.sourceforge.net>
 <20170425115446.GC7926@amd>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170425115446.GC7926@amd>
User-Agent: NeoMutt/20170113 (1.7.2)
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

1) That allocation will never fail in real life so it's dead code.
2) kmalloc and friends already have much better builtin in error
   messages so it's useless.
3) There is a small memory savings from removing it.

I'm not saying you should apply the patch, I'm just saying that these
messages are pointless and detrimental.

regards,
an carpenter