From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948354AbdDYOpp (ORCPT ); Tue, 25 Apr 2017 10:45:45 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:36497 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948318AbdDYOp1 (ORCPT ); Tue, 25 Apr 2017 10:45:27 -0400 From: Gary Bisson To: rtc-linux@googlegroups.com Cc: linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, a.zummo@towertech.it, Gary Bisson Subject: [PATCH 1/4] rtc: m41t80: fix SQWE override when setting an alarm Date: Tue, 25 Apr 2017 16:45:14 +0200 Message-Id: <20170425144517.15962-2-gary.bisson@boundarydevices.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170425144517.15962-1-gary.bisson@boundarydevices.com> References: <20170425144517.15962-1-gary.bisson@boundarydevices.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently setting an alarm clears the SQWE bit which means that the clock output is disabled no matter its previous state. Signed-off-by: Gary Bisson --- drivers/rtc/rtc-m41t80.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index 58698d21c2c3..93684ab293f2 100644 --- a/drivers/rtc/rtc-m41t80.c +++ b/drivers/rtc/rtc-m41t80.c @@ -273,6 +273,9 @@ static int m41t80_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) return err; } + /* Keep SQWE bit value */ + alarmvals[0] |= (ret & M41T80_ALMON_SQWE); + ret = i2c_smbus_read_byte_data(client, M41T80_REG_FLAGS); if (ret < 0) return ret; -- 2.11.0