From: Sabrina Dubroca <sd@queasysnail.net>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: Netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
stable@vger.kernel.org, security@kernel.org
Subject: Re: [PATCH v2] macsec: dynamically allocate space for sglist
Date: Tue, 25 Apr 2017 22:35:55 +0200 [thread overview]
Message-ID: <20170425203555.GA9378@bistromath.localdomain> (raw)
In-Reply-To: <20170425170818.32661-1-Jason@zx2c4.com>
2017-04-25, 19:08:18 +0200, Jason A. Donenfeld wrote:
> We call skb_cow_data, which is good anyway to ensure we can actually
> modify the skb as such (another error from prior). Now that we have the
> number of fragments required, we can safely allocate exactly that amount
> of memory.
>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: Sabrina Dubroca <sd@queasysnail.net>
> Cc: security@kernel.org
> Cc: stable@vger.kernel.org
Acked-by: Sabrina Dubroca <sd@queasysnail.net>
Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver")
Fixes: CVE-2017-7477
David, this fix is essentially equivalent to my patch "macsec: avoid
heap overflow in skb_to_sgvec on receive". Feel free to pick my patch
if you prefer (it's smaller), but this looks ok to me.
Thanks,
--
Sabrina
next prev parent reply other threads:[~2017-04-25 20:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:14 [PATCH] macsec: avoid heap overflow in skb_to_sgvec Jason A. Donenfeld
2017-04-24 11:02 ` David Laight
2017-04-24 12:15 ` Jason A. Donenfeld
2017-04-24 17:47 ` David Miller
2017-04-25 14:53 ` Sabrina Dubroca
2017-04-25 15:08 ` Jason A. Donenfeld
2017-04-25 15:12 ` Sabrina Dubroca
2017-04-25 15:13 ` Jason A. Donenfeld
2017-04-25 15:23 ` [PATCH] macsec: dynamically allocate space for sglist Jason A. Donenfeld
2017-04-25 16:36 ` Sabrina Dubroca
2017-04-25 17:08 ` [PATCH v2] " Jason A. Donenfeld
2017-04-25 20:35 ` Sabrina Dubroca [this message]
2017-04-26 18:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425203555.GA9378@bistromath.localdomain \
--to=sd@queasysnail.net \
--cc=Jason@zx2c4.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=security@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).