From: Mark Greer <mgreer@animalcreek.com>
To: Geoff Lansberry <geoff@kuvee.com>
Cc: linux-wireless@vger.kernel.org, sameo@linux.intel.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nfc@ml01.01.org, devicetree@vger.kernel.org,
mgreer@animalcreek.com, justin@kuvee.com,
colin.king@canonical.com, wharms@bfs.de
Subject: Re: [PATCH v3] NFC: trf7970a: Correct register settings for 27MHz clock
Date: Thu, 27 Apr 2017 10:19:37 -0700 [thread overview]
Message-ID: <20170427171937.GA21522@animalcreek.com> (raw)
In-Reply-To: <1493304119-16605-1-git-send-email-geoff@kuvee.com>
On Thu, Apr 27, 2017 at 10:41:59AM -0400, Geoff Lansberry wrote:
> In prior commits the selected clock frequency does not propagate
> correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL
^^^^^^^
s/the the/to the/
> register.
>
> Signed-off-by: Geoff Lansberry <geoff@kuvee.com>
> ---
> drivers/nfc/trf7970a.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
> index 6ed5d7e..f7fee7d 100644
> --- a/drivers/nfc/trf7970a.c
> +++ b/drivers/nfc/trf7970a.c
> @@ -2067,6 +2067,13 @@ static int trf7970a_probe(struct spi_device *spi)
> return -EINVAL;
> }
>
> + if (clk_freq == TRF7970A_27MHZ_CLOCK_FREQUENCY) {
> + trf->modulator_sys_clk_ctrl = TRF7970A_MODULATOR_27MHZ;
> + dev_dbg(trf->dev, "trf7970a configured for 27MHz crystal\n");
> + } else {
> + trf->modulator_sys_clk_ctrl = 0;
> + }
> +
> ret = devm_request_threaded_irq(trf->dev, spi->irq, NULL,
> trf7970a_irq,
> IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> --
> 2.7.4
With the suggested fix above:
Acked-by: Mark Greer <mgreer@animalcreek.com>
prev parent reply other threads:[~2017-04-27 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 14:41 [PATCH v3] NFC: trf7970a: Correct register settings for 27MHz clock Geoff Lansberry
2017-04-27 17:19 ` Mark Greer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427171937.GA21522@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=colin.king@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=geoff@kuvee.com \
--cc=justin@kuvee.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@ml01.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).