From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1162923AbdD1ULQ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Apr 2017 16:11:16 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:58794 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754920AbdD1ULC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Apr 2017 16:11:02 -0400
Date: Fri, 28 Apr 2017 16:10:50 -0400 (EDT)
Message-Id: <20170428.161050.111916772197901326.davem@davemloft.net>
To: lixiaoping3@huawei.com
Cc: huangdaode@hisilicon.com, lipeng321@huawei.com,
        yisen.zhuang@huawei.com, salil.mehta@huawei.com, yankejian@huawei.com,
        mbrugger@suse.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH net] net: hns: fix ethtool_get_strings overflow in hns
 driver
From: David Miller <davem@davemloft.net>
In-Reply-To: <20170427141816.301212-1-lixiaoping3@huawei.com>
References: <20170427141816.301212-1-lixiaoping3@huawei.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 28 Apr 2017 12:29:27 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Timmy Li <lixiaoping3@huawei.com>
Date: Thu, 27 Apr 2017 22:18:16 +0800

> @@ -672,7 +672,7 @@ static void hns_gmac_get_strings(u32 stringset, u8 *data)
>  
>  static int hns_gmac_get_sset_count(int stringset)
>  {
> -	if (stringset == ETH_SS_STATS)
> +	if ((stringset == ETH_SS_STATS) || (stringset == ETH_SS_PRIV_FLAGS))

Excessive parenthesis, please fix this in your entire patch.

Thank you.