From: David Miller <davem@davemloft.net>
To: andreas@kemnade.info
Cc: joe@perches.com, gregkh@linuxfoundation.org,
peter@hurleysoftware.com, hns@goldelico.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hso: register netdev later to avoid a race condition
Date: Fri, 28 Apr 2017 16:12:15 -0400 (EDT) [thread overview]
Message-ID: <20170428.161215.1554269734409048791.davem@davemloft.net> (raw)
In-Reply-To: <1493227600-10102-1-git-send-email-andreas@kemnade.info>
From: Andreas Kemnade <andreas@kemnade.info>
Date: Wed, 26 Apr 2017 19:26:40 +0200
> If the netdev is accessed before the urbs are initialized,
> there will be NULL pointer dereferences. That is avoided by
> registering it when it is fully initialized.
>
> This case occurs e.g. if dhcpcd is running in the background
> and the device is probed, either after insmod hso or
> when the device appears on the usb bus.
>
> A backtrace is the following:
...
> Reported-by: H. Nikolaus Schaller <hns@goldelico.com>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Applied, thanks.
prev parent reply other threads:[~2017-04-28 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 17:26 [PATCH] net: hso: register netdev later to avoid a race condition Andreas Kemnade
2017-04-27 8:44 ` Johan Hovold
2017-04-28 17:36 ` Andreas Kemnade
2017-04-28 19:00 ` Johan Hovold
2017-04-28 20:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428.161215.1554269734409048791.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andreas@kemnade.info \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).