From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1036199AbdD1UMl (ORCPT ); Fri, 28 Apr 2017 16:12:41 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:58826 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1035554AbdD1UMR (ORCPT ); Fri, 28 Apr 2017 16:12:17 -0400 Date: Fri, 28 Apr 2017 16:12:15 -0400 (EDT) Message-Id: <20170428.161215.1554269734409048791.davem@davemloft.net> To: andreas@kemnade.info Cc: joe@perches.com, gregkh@linuxfoundation.org, peter@hurleysoftware.com, hns@goldelico.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: hso: register netdev later to avoid a race condition From: David Miller In-Reply-To: <1493227600-10102-1-git-send-email-andreas@kemnade.info> References: <1493227600-10102-1-git-send-email-andreas@kemnade.info> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 28 Apr 2017 12:30:51 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andreas Kemnade Date: Wed, 26 Apr 2017 19:26:40 +0200 > If the netdev is accessed before the urbs are initialized, > there will be NULL pointer dereferences. That is avoided by > registering it when it is fully initialized. > > This case occurs e.g. if dhcpcd is running in the background > and the device is probed, either after insmod hso or > when the device appears on the usb bus. > > A backtrace is the following: ... > Reported-by: H. Nikolaus Schaller > Signed-off-by: Andreas Kemnade Applied, thanks.