From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424063AbdD1GnC (ORCPT ); Fri, 28 Apr 2017 02:43:02 -0400 Received: from mga09.intel.com ([134.134.136.24]:34073 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030875AbdD1Gmy (ORCPT ); Fri, 28 Apr 2017 02:42:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="254496563" Date: Fri, 28 Apr 2017 14:38:09 +0800 From: Wu Hao To: Alan Tull Cc: Moritz Fischer , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: Re: [PATCH v2 16/16] fpga: region: move device tree support to of-fpga-region.c Message-ID: <20170428063809.GA1335@hao-dev> References: <1492697401-11211-1-git-send-email-atull@kernel.org> <1492697401-11211-17-git-send-email-atull@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492697401-11211-17-git-send-email-atull@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 20, 2017 at 09:10:01AM -0500, Alan Tull wrote: > Create of-fpga-region.c > > Move the following functions without modification from > fpga-region.c to of-fpga-region.c: > > * of_fpga_region_find > * of_fpga_region_get_mgr > * of_fpga_region_get_bridges > * child_regions_with_firmware > * of_fpga_region_parse_ov > * of_fpga_region_notify_pre_apply > * of_fpga_region_notify_post_remove > * of_fpga_region_notify > * of_fpga_region_probe > * of_fpga_region_remove > > Create two new function with some code from fpga_region_init/exit. > > * of_fpga_region_init > * of_fpga_region_exit > > Signed-off-by: Alan Tull > --- > v2: split out code changes into other patches, only move code here > --- > drivers/fpga/Kconfig | 13 +- > drivers/fpga/Makefile | 1 + > drivers/fpga/fpga-region.c | 449 +------------------------------------- > drivers/fpga/of-fpga-region.c | 493 ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 505 insertions(+), 451 deletions(-) > create mode 100644 drivers/fpga/of-fpga-region.c > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig > index 161ba9d..394c141 100644 > --- a/drivers/fpga/Kconfig > +++ b/drivers/fpga/Kconfig > @@ -15,10 +15,17 @@ if FPGA > > config FPGA_REGION > tristate "FPGA Region" > - depends on OF && FPGA_BRIDGE > + depends on FPGA_BRIDGE > + help > + FPGA Region common code. A FPGA Region controls a FPGA Manager > + and the FPGA Bridges associated with either a reconfigurable > + region of an FPGA or a whole FPGA. > + Hi Alan As FPGA_BRIDGE depends on OF, so FPGA_REGION still can't be selected without OF. Should we remove the OF dependency for FPGA_BRIDGE as well? Thanks Hao