From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939826AbdD1JoB (ORCPT ); Fri, 28 Apr 2017 05:44:01 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:55022 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755998AbdD1Jn6 (ORCPT ); Fri, 28 Apr 2017 05:43:58 -0400 From: Arnd Bergmann To: Rob Herring , Frank Rowand Cc: Arnd Bergmann , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] of: fix uninitialized variable warning for overlay test Date: Fri, 28 Apr 2017 11:44:11 +0200 Message-Id: <20170428094429.2396195-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Dm0O+a+wr4Z/EdftEt7TGjeUo3dAvAw1FrQ+JNBuH11fV2TcLx8 +WJyGgYJ3otLOLEku10ls7QEcDzo8joagCEOT2ALGjZ4gVUm6SSlkYnc4ECwTB53OXn2ljU ENuAvA3SFfqW7xSBh5i69RYaWgOhuiY/Do7/mD711QyiIlTO+kenhArgtLEYmUyXoCbc8lX qxcV9iulz/cRrMRTq/rtA== X-UI-Out-Filterresults: notjunk:1;V01:K0:hGcCaJr8UNE=:aaGMkclU/nLvuO6sQ5ES5/ GHOhN8PJYdpceP4Bv0rhVGFnOFtlNRVz8Xu5mPHBXdgQOuiyYlhI5P39hKUuy4LiiJT0kJe4P 6Uk3YdMY/PRrinqz1Qkm/ZtlvtRg3jQs+ViOkQkE6DY8IWOdvMUuu7oEB0Q0e13wtVczZGnLC EGJ1zWBBROXheO2JX23/av9RBhBNuoXSy/kusZ8GIOeZN4fXuT6hoyyuGcf3aryAUGo7pbswN 4Gj6U4b/+sAsDsLnQkluSHbixKn6EgYO6YWT344YVav9JqLxd9Yj9pE7mcqc2RDqySdGWEsaE mK/DoSoaUkdB7AyizGD/0zNZgMBHhn6IkWNWv1NZx4i3ucwoRCdEQUQEukehlOZXE2D0SCbfd pUorvSNbzssP+m9NJBgNkJM8PSp3RcQTGvWfEK6PNknkpxHIYEwDOB09SKrMT94sd1C8KjUgq 3FNZFhaaeefLFKtaBT6ILr1uVAQ8j9Kdm4iLkjmDA2RlDlPcu8PAPgixPpmi3JZEq7gSA3BBA JxAUxIegSewfyNqqwf3bF9EUU9Hc/TGF3cyBq9fMZiMS+8x43lLt/JDoA7HPtVLDvzpnvu2wG O337hHFNhrWJY2aa8A3P9BzVLLfamQBZkrm6U/317GF/rsWmB+fAmDlhf8mpbQFKCliPg5MM6 UV04eyNXsD0tb4pps5ydqZq1XDTjvUb9DmnqZ0ti4ed9KN8GB4h91kmDolBWPPVl6xco= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc warns that an empty device tree would cause undefined behavior: drivers/of/unittest.c: In function 'of_unittest': drivers/of/unittest.c:2199:25: warning: 'last_sibling' may be used uninitialized in this function [-Wmaybe-uninitialized] This adds an initialization of the variable to zero, which we handle correctly. Fixes: 81d0848fc8d2 ("of: Add unit tests for applying overlays") Signed-off-by: Arnd Bergmann --- drivers/of/unittest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 12597ff8cfb0..6b8f3e6aa43c 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -2192,7 +2192,7 @@ static __init void of_unittest_overlay_high_level(void) mutex_lock(&of_mutex); - for (np = of_root->child; np; np = np->sibling) + for (last_sibling = np = of_root->child; np; np = np->sibling) last_sibling = np; if (last_sibling) -- 2.9.0