From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Darren Hart (VMware)" <dvhart@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andy@infradead.org>,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD
Date: Fri, 28 Apr 2017 14:09:00 -0700 [thread overview]
Message-ID: <20170428210900.GG4949@dtor-ws> (raw)
In-Reply-To: <20170428210019.GA32026@fury>
On Fri, Apr 28, 2017 at 02:00:19PM -0700, Darren Hart (VMware) wrote:
> SILEAD_DMI provides platform specific data for the TOUCHSCREEN_SILEAD
> driver. Make this explicitly clear in the Kconfig depends.
>
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 9e5b2c2..5690664 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1101,7 +1101,7 @@ config INTEL_TURBO_MAX_3
>
> config SILEAD_DMI
> bool "Tablets with Silead touchscreens"
> - depends on ACPI && DMI && I2C=y && INPUT
> + depends on ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
Bikeshed: TOUCHSCREEN_SILEAD already depends on INPUT, so you can drop
INPUT dependency.
Otherwise
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
--
Dmitry
next prev parent reply other threads:[~2017-04-28 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 21:00 [PATCH] platform/x86: Make SILEAD_DMI depend on TOUCHSCREEN_SILEAD Darren Hart (VMware)
2017-04-28 21:09 ` Dmitry Torokhov [this message]
2017-04-28 22:14 ` Darren Hart
2017-05-03 6:28 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428210900.GG4949@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).