linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Kaiser <martin@kaiser.cx>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry
Date: Sat, 29 Apr 2017 09:05:15 +0200	[thread overview]
Message-ID: <20170429070515.GB29622@botnar.kaiser.cx> (raw)
In-Reply-To: <CAHp75Vec84Ltp2oGQwCKv9CwhzTFCu0znR_tmoLstctn_UR88A@mail.gmail.com>

Hello Andy,

Thus wrote Andy Shevchenko (andy.shevchenko@gmail.com):

> On Tue, Apr 18, 2017 at 12:11 PM, Martin Kaiser <martin@kaiser.cx> wrote:

> > checkpatch is asking for a 4 digit octal number. And at least for me,
> > 0444 makes it clearer what the permissions actually are. Yes, somewhere
> > in the code, I can dig up that 0 is changed to 0444...

> Aren't 0 and 0444 different by meaning?

my undestanding is that proc_create() calls proc_create_data(), where

   if ((mode & S_IALLUGO) == 0)
      mode |= S_IRUGO;

sets mode to 0444 when it was 0.

Best regards,
Martin

(added the lkml back to Cc, I removed it by accident in an earlier mail)

  parent reply	other threads:[~2017-04-29  7:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 22:27 [PATCH] char: misc: minor code cleanup Martin Kaiser
2017-04-08 16:11 ` Greg Kroah-Hartman
2017-04-17 18:22 ` [PATCH 1/2 v2] char: misc: move the EXPORT_SYMBOL() declarations Martin Kaiser
2017-04-17 18:22   ` [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry Martin Kaiser
2017-04-18  4:31     ` Greg Kroah-Hartman
2017-04-18  7:51       ` Martin Kaiser
2017-04-18  8:15         ` Greg Kroah-Hartman
2017-04-18  9:11           ` Martin Kaiser
     [not found]             ` <CAHp75Vec84Ltp2oGQwCKv9CwhzTFCu0znR_tmoLstctn_UR88A@mail.gmail.com>
2017-04-29  7:05               ` Martin Kaiser [this message]
2017-04-30 12:52                 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170429070515.GB29622@botnar.kaiser.cx \
    --to=martin@kaiser.cx \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).