Hi, On Sun, Apr 30, 2017 at 08:21:51AM +0300, Alex A. Mihaylov wrote: > > > Slave device provide software layer for access to internal registers > > > MAX17211/MAX17215 chip. > > Please convert this to regmap.There is no generic w1 handler, but you can provide custom > > read/write functions. > I think regmap be overkill for this driver. Here we need access to a small > number of registers. Registers are extremely simple on the internal device. > As a result, the software layer of regmap will only complicate the > readability and understanding of the code. And also increase the size and > time of code execution, and even complicate the perception. I did not ask for full usage of all regmap features. Just register the read/write handler as regmap handler and use regmap_read/write to get values. -- Sebastian