linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs: Fix coding style issues
@ 2017-05-01 10:49 Adheer Chandravanshi
  2017-05-01 12:10 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Adheer Chandravanshi @ 2017-05-01 10:49 UTC (permalink / raw)
  To: gregkh, insafonov, hdegoede, luca, devel, linux-kernel

Fix style issues as reported by checkpatch.pl

Signed-off-by: Adheer Chandravanshi <adheerchandravanshi@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtl8192c_recv.h |  9 +++++----
 drivers/staging/rtl8723bs/include/rtl8192c_rf.h   | 22 +++++++++-------------
 2 files changed, 14 insertions(+), 17 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
index 3e1be00..09e3c49 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
@@ -21,8 +21,7 @@
 
 #define MAX_RECVBUF_SZ (10240)
 
-struct phy_stat
-{
+struct phy_stat {
 	unsigned int phydw0;
 
 	unsigned int phydw1;
@@ -44,7 +43,9 @@ struct phy_stat
 #define	Rx_Smooth_Factor (20)
 
 
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
+void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe,
+					struct phy_stat *pphy_status);
+void rtl8192c_query_rx_desc_status(union recv_frame *precvframe,
+				   struct recv_stat *pdesc);
 
 #endif
diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_rf.h b/drivers/staging/rtl8723bs/include/rtl8192c_rf.h
index 0dbee56..d3105c0 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_rf.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_rf.h
@@ -19,19 +19,15 @@
 /*  */
 /*  RF RL6052 Series API */
 /*  */
-void 	rtl8192c_RF_ChangeTxPath(struct adapter *Adapter,
-				u16 	DataRate);
-void 	rtl8192c_PHY_RF6052SetBandwidth(
-				struct adapter *			Adapter,
-				enum CHANNEL_WIDTH		Bandwidth);
-void rtl8192c_PHY_RF6052SetCckTxPower(
-				struct adapter *Adapter,
-				u8*	pPowerlevel);
-void rtl8192c_PHY_RF6052SetOFDMTxPower(
-				struct adapter *Adapter,
-				u8*	pPowerLevel,
-				u8 Channel);
-int	PHY_RF6052_Config8192C(struct adapter *	Adapter	);
+void rtl8192c_RF_ChangeTxPath(struct adapter *Adapter,
+			      u16 DataRate);
+void rtl8192c_PHY_RF6052SetBandwidth(struct adapter *Adapter,
+				     enum CHANNEL_WIDTH Bandwidth);
+void rtl8192c_PHY_RF6052SetCckTxPower(struct adapter *Adapter,
+				      u8 *pPowerlevel);
+void rtl8192c_PHY_RF6052SetOFDMTxPower(struct adapter *Adapter,
+				       u8 *pPowerLevel, u8 Channel);
+int PHY_RF6052_Config8192C(struct adapter *Adapter);
 
 /*--------------------------Exported Function prototype---------------------*/
 
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: rtl8723bs: Fix coding style issues
  2017-05-01 10:49 [PATCH] staging: rtl8723bs: Fix coding style issues Adheer Chandravanshi
@ 2017-05-01 12:10 ` Greg KH
  2017-05-02  4:32   ` adheer chandravanshi
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2017-05-01 12:10 UTC (permalink / raw)
  To: Adheer Chandravanshi; +Cc: insafonov, hdegoede, luca, devel, linux-kernel

On Mon, May 01, 2017 at 04:19:48PM +0530, Adheer Chandravanshi wrote:
> Fix style issues as reported by checkpatch.pl

That's really vague, you need to be specific, and only fix one type of
thing per patch.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] staging: rtl8723bs: Fix coding style issues
  2017-05-01 12:10 ` Greg KH
@ 2017-05-02  4:32   ` adheer chandravanshi
  0 siblings, 0 replies; 3+ messages in thread
From: adheer chandravanshi @ 2017-05-02  4:32 UTC (permalink / raw)
  To: Greg KH; +Cc: Ivan Safonov, hdegoede, Luca Ceresoli, devel, linux-kernel

On Mon, May 1, 2017 at 5:40 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, May 01, 2017 at 04:19:48PM +0530, Adheer Chandravanshi wrote:
>> Fix style issues as reported by checkpatch.pl
>
> That's really vague, you need to be specific, and only fix one type of
> thing per patch.
>
> thanks,
>
> greg k-h

Thanks for the quick review, will re-send the patch.

--
Adheer

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-02  4:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-01 10:49 [PATCH] staging: rtl8723bs: Fix coding style issues Adheer Chandravanshi
2017-05-01 12:10 ` Greg KH
2017-05-02  4:32   ` adheer chandravanshi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).