From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1946033AbdEAOjp (ORCPT <rfc822;w@1wt.eu>);
        Mon, 1 May 2017 10:39:45 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:59930 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1425795AbdEAOjg (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 1 May 2017 10:39:36 -0400
Date: Mon, 1 May 2017 07:39:30 -0700
From: Matthew Wilcox <willy@infradead.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mm/slub: wrap cpu_slab->partial in
 CONFIG_SLUB_CPU_PARTIAL
Message-ID: <20170501143930.GJ27790@bombadil.infradead.org>
References: <20170430113152.6590-1-richard.weiyang@gmail.com>
 <20170430113152.6590-3-richard.weiyang@gmail.com>
 <20170501024103.GI27790@bombadil.infradead.org>
 <20170501082005.GA2006@WeideMacBook-Pro.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170501082005.GA2006@WeideMacBook-Pro.local>
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 01, 2017 at 04:20:05PM +0800, Wei Yang wrote:
> I have tried to replace the code with slub_cpu_partial(), it works fine on
> most of cases except two:
> 
> 1. slub_cpu_partial(c) = page->next;

New accessor: slub_set_cpu_partial(c, p)

> 2. page = READ_ONCE(slub_cpu_partial(c));

OK, that one I haven't seen an existing pattern for yet.
slub_cpu_partial_read_once(c)?