linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: gapalinux <gapalinux@gmail.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: gregkh@linuxfoundation.org, wsa@the-dreams.de,
	karniksayli1995@gmail.com, shiva@exdev.nl, bhumirks@gmail.com,
	mattkilgore12@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr
Date: Mon, 1 May 2017 16:11:30 +0200	[thread overview]
Message-ID: <20170501161130.4302156b@gapa-Lenovo-IdeaPad-Y580> (raw)
In-Reply-To: <20170501095944.GL21332@eros>

On Mon, 1 May 2017 19:59:44 +1000
"Tobin C. Harding" <me@tobin.cc> wrote:

> On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote:
> > Sparse spits out a warnings about __le16 and unsigned short
> > assignment. Change the type of size and event members of struct
> > hostif_hdr to __le16 and correct conversion to the proper cpu type.
> > 
> > Signed-off-by: Cezary Gapinski <gapalinux@gmail.com>  
> 
> After discussion on kernelnewbies mailing list and thinking about this
> for a couple of days I am now of the opinion that this patch is
> merge-able. I am probably not fully qualified to say so but no one
> else appears to be super active on this driver. If I am wrong, I'll be
> here to fix it up :)
> 
>  Reviewed-by: Tobin C. Harding <me@tobin.cc>
> 
> Good work Cezsary, apologies for the wish-washy replies. I'm learning
> also ;)
> 
> Good luck,
> Tobin.

Hi Tobin,

nice to know that you also thinking about this fixes. I think that is
just a first step because I noticed much more warning with
big/little-endian issues and perhaps no one else want to touch this.
I'm also here to help if it is something will be incorrect ;)."

Sorry for my previous messages. Sometimes I forget about crtl+s will
sending my e-mails, so if you received other messages just ignore it.

> > ---
> >  drivers/staging/ks7010/ks7010_sdio.c | 10 ++++++----
> >  drivers/staging/ks7010/ks_hostif.h   |  4 ++--
> >  2 files changed, 8 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/staging/ks7010/ks7010_sdio.c
> > b/drivers/staging/ks7010/ks7010_sdio.c index ec11799..e3a134d 100644
> > --- a/drivers/staging/ks7010/ks7010_sdio.c
> > +++ b/drivers/staging/ks7010/ks7010_sdio.c
> > @@ -269,7 +269,8 @@ static int write_to_device(struct
> > ks_wlan_private *priv, unsigned char *buffer, hdr = (struct
> > hostif_hdr *)buffer; 
> >  	DPRINTK(4, "size=%d\n", hdr->size);
> > -	if (hdr->event < HIF_DATA_REQ || HIF_REQ_MAX < hdr->event)
> > {
> > +	if (le16_to_cpu(hdr->event) < HIF_DATA_REQ ||
> > +	    le16_to_cpu(hdr->event) > HIF_REQ_MAX) {
> >  		DPRINTK(1, "unknown event=%04X\n", hdr->event);
> >  		return 0;
> >  	}
> > @@ -327,13 +328,14 @@ int ks_wlan_hw_tx(struct ks_wlan_private
> > *priv, void *p, unsigned long size, 
> >  	hdr = (struct hostif_hdr *)p;
> >  
> > -	if (hdr->event < HIF_DATA_REQ || HIF_REQ_MAX < hdr->event)
> > {
> > +	if (le16_to_cpu(hdr->event) < HIF_DATA_REQ ||
> > +	    le16_to_cpu(hdr->event) > HIF_REQ_MAX) {
> >  		DPRINTK(1, "unknown event=%04X\n", hdr->event);
> >  		return 0;
> >  	}
> >  
> >  	/* add event to hostt buffer */
> > -	priv->hostt.buff[priv->hostt.qtail] = hdr->event;
> > +	priv->hostt.buff[priv->hostt.qtail] =
> > le16_to_cpu(hdr->event); priv->hostt.qtail = (priv->hostt.qtail +
> > 1) % SME_EVENT_BUFF_SIZE; 
> >  	DPRINTK(4, "event=%04X\n", hdr->event);
> > @@ -403,7 +405,7 @@ static void ks_wlan_hw_rx(struct
> > ks_wlan_private *priv, uint16_t size) 
> >  	hdr = (struct hostif_hdr *)&rx_buffer->data[0];
> >  	rx_buffer->size = le16_to_cpu(hdr->size) +
> > sizeof(hdr->size);
> > -	event = hdr->event;
> > +	event = le16_to_cpu(hdr->event);
> >  	inc_rxqtail(priv);
> >  
> >  	ret = ks7010_sdio_writeb(priv, READ_STATUS,
> > REG_STATUS_IDLE); diff --git a/drivers/staging/ks7010/ks_hostif.h
> > b/drivers/staging/ks7010/ks_hostif.h index d773432..7e4d1aa 100644
> > --- a/drivers/staging/ks7010/ks_hostif.h
> > +++ b/drivers/staging/ks7010/ks_hostif.h
> > @@ -62,8 +62,8 @@
> >   */
> >  
> >  struct hostif_hdr {
> > -	u16 size;
> > -	u16 event;
> > +	__le16 size;
> > +	__le16 event;
> >  } __packed;
> >  
> >  struct hostif_data_request_t {
> > -- 
> > 2.7.4
> >   

  reply	other threads:[~2017-05-01 14:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-29 17:54 Cezary Gapinski
2017-04-30  8:00 ` Tobin C. Harding
2017-05-01  9:59 ` Tobin C. Harding
2017-05-01 14:11   ` gapalinux [this message]
2017-05-01 21:31     ` Tobin C. Harding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170501161130.4302156b@gapa-Lenovo-IdeaPad-Y580 \
    --to=gapalinux@gmail.com \
    --cc=bhumirks@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=karniksayli1995@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattkilgore12@gmail.com \
    --cc=me@tobin.cc \
    --cc=shiva@exdev.nl \
    --cc=wsa@the-dreams.de \
    --subject='Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).