linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Martin Kepplinger <martink@posteo.de>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter
Date: Mon, 1 May 2017 10:11:43 -0700	[thread overview]
Message-ID: <20170501171143.GB7851@dtor-ws> (raw)
In-Reply-To: <20170501145709.9803-1-martink@posteo.de>

On Mon, May 01, 2017 at 04:57:09PM +0200, Martin Kepplinger wrote:
> The recent change
> 
> commit 2098cc15d9a0 ("Input: ar1021_i2c - enable touch mode during open")
> 
> also removed the ABS_X input code to be set. This must have been done
> by mistake; so we bring back the X axis!
> 
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> 
> Dmitry,
> 
> this must have slipped in somehow. I didn't have this mistake included:
> https://www.spinics.net/lists/linux-input/msg51103.html

I must have fat-fingered it somehow. I fixed up the original commit
since it wasn't buried too deep.

Thanks.

> 
> thanks
>                          martin
> 
> 
>  drivers/input/touchscreen/ar1021_i2c.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
> index ff59c3a383d6..3f55f673f661 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -118,6 +118,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
>  	input->close = ar1021_i2c_close;
>  
>  	input_set_capability(input, EV_KEY, BTN_TOUCH);
> +	input_set_abs_params(input, ABS_X, 0, AR1021_MAX_X, 0, 0);
>  	input_set_abs_params(input, ABS_Y, 0, AR1021_MAX_Y, 0, 0);
>  
>  	input_set_drvdata(input, ar1021);
> -- 
> 2.11.0
> 

-- 
Dmitry

      reply	other threads:[~2017-05-01 17:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-01 14:57 Martin Kepplinger
2017-05-01 17:11 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170501171143.GB7851@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martink@posteo.de \
    --subject='Re: [PATCH] input: ar1021_i2c: add previously wrongly removed ABS_X parameter' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).