linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: gapalinux <gapalinux@gmail.com>
Cc: gregkh@linuxfoundation.org, wsa@the-dreams.de,
	karniksayli1995@gmail.com, shiva@exdev.nl, bhumirks@gmail.com,
	mattkilgore12@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr
Date: Tue, 2 May 2017 07:31:34 +1000	[thread overview]
Message-ID: <20170501213134.GA6132@eros> (raw)
In-Reply-To: <20170501161130.4302156b@gapa-Lenovo-IdeaPad-Y580>

On Mon, May 01, 2017 at 04:11:30PM +0200, gapalinux wrote:
> On Mon, 1 May 2017 19:59:44 +1000
> "Tobin C. Harding" <me@tobin.cc> wrote:
> 
> > On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote:
> > > Sparse spits out a warnings about __le16 and unsigned short
> > > assignment. Change the type of size and event members of struct
> > > hostif_hdr to __le16 and correct conversion to the proper cpu type.
> > > 
> > > Signed-off-by: Cezary Gapinski <gapalinux@gmail.com>  
> > 
> > After discussion on kernelnewbies mailing list and thinking about this
> > for a couple of days I am now of the opinion that this patch is
> > merge-able. I am probably not fully qualified to say so but no one
> > else appears to be super active on this driver. If I am wrong, I'll be
> > here to fix it up :)
> > 
> >  Reviewed-by: Tobin C. Harding <me@tobin.cc>
> > 
> > Good work Cezsary, apologies for the wish-washy replies. I'm learning
> > also ;)
> > 
> > Good luck,
> > Tobin.
> 
> Hi Tobin,
> 
> nice to know that you also thinking about this fixes. I think that is
> just a first step because I noticed much more warning with
> big/little-endian issues and perhaps no one else want to touch this.

I did up a patch set yesterday that fixes most of the Sparse
warnings. It was simply a matter of changing all struct members in
ks_hostif.h to be __leXX and adding a few cpu_to_leXX()/leXX_to_cpu()
calls. Exactly as you did. I'm going to wait for your patch, and
another that is in flight on ks7010, to be merged before I submit
it. There will still be a few Sparse warnings that are a little more
tricky, so there is still some fun to be had.

> I'm also here to help if it is something will be incorrect ;)."

Cool

> Sorry for my previous messages. Sometimes I forget about crtl+s will
> sending my e-mails, so if you received other messages just ignore it.

Didn't receive any extra messages :)

Cheers,
Tobin.

      reply	other threads:[~2017-05-01 21:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-29 17:54 Cezary Gapinski
2017-04-30  8:00 ` Tobin C. Harding
2017-05-01  9:59 ` Tobin C. Harding
2017-05-01 14:11   ` gapalinux
2017-05-01 21:31     ` Tobin C. Harding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170501213134.GA6132@eros \
    --to=me@tobin.cc \
    --cc=bhumirks@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gapalinux@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=karniksayli1995@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattkilgore12@gmail.com \
    --cc=shiva@exdev.nl \
    --cc=wsa@the-dreams.de \
    --subject='Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).