From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751076AbdEAWxp (ORCPT ); Mon, 1 May 2017 18:53:45 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:33410 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdEAWxn (ORCPT ); Mon, 1 May 2017 18:53:43 -0400 Date: Mon, 1 May 2017 23:53:39 +0100 From: Tuomo To: Greg KH Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: rtl8192u: Convert u4bAcParam back to little-endian after construction Message-ID: <20170501225339.GA6791@aegis.tuomo.info> References: <201704300251.pp76BnC7%fengguang.wu@intel.com> <1493658718-4594-1-git-send-email-tuomo.rinne@gmail.com> <1493658718-4594-2-git-send-email-tuomo.rinne@gmail.com> <20170501213435.GA29029@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170501213435.GA29029@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 01, 2017 at 02:34:36PM -0700, Greg KH wrote: > On Mon, May 01, 2017 at 06:11:58PM +0100, Tuomo Rinne wrote: > > > > The commit 9304b5b0d4fe ("staging: rtl8192u: Fix sparse warnings in r8192U_dm.c") > > adds casting of le16 from cpu endianness. > > This patch converts the u4bAcParam parameter back to little-endian after > > it has been constructed. > > > > Signed-off-by: Tuomo Rinne > > --- > > drivers/staging/rtl8192u/r8192U_dm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c > > index 283dda4..fd8225c 100644 > > --- a/drivers/staging/rtl8192u/r8192U_dm.c > > +++ b/drivers/staging/rtl8192u/r8192U_dm.c > > @@ -2321,10 +2321,10 @@ static void dm_check_edca_turbo( > > u1bAIFS <<= AC_PARAM_AIFS_OFFSET; > > > > u4bAcParam = op_limit | cw_max | cw_min | u1bAIFS; > > + cpu_to_le32s(u4bAcParam); > > > > write_nic_dword(dev, EDCAPARA_BE, u4bAcParam); > > > > - > > Why is this line removed? > > thanks, > > greg k-h Hi, I cleaned up the commit and resubmitted the patchset. Thanks, Tuomo