From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751490AbdEBHYy (ORCPT <rfc822;w@1wt.eu>);
        Tue, 2 May 2017 03:24:54 -0400
Received: from mail-wr0-f195.google.com ([209.85.128.195]:36196 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750752AbdEBHYx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 May 2017 03:24:53 -0400
Date: Tue, 2 May 2017 09:24:49 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Baoquan He <bhe@redhat.com>
Cc: Yinghai Lu <yinghai@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Thomas Garnier <thgarnie@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yasuaki Ishimatsu <yasu.isimatu@gmail.com>,
        Jinbum Park <jinb.park7@gmail.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH] x86/mm: Fix incorrect for loop count calculation in
 sync_global_pgds
Message-ID: <20170502072449.i755v4qtef3mibdb@gmail.com>
References: <1493638874-4014-1-git-send-email-bhe@redhat.com>
 <CAE9FiQXWCydwTKEwm2naxq21o1ODh0jEO3m0FmtNZsLT=TbwSA@mail.gmail.com>
 <20170502071837.GA2579@x1>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170502071837.GA2579@x1>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Baoquan He <bhe@redhat.com> wrote:

> On 05/01/17 at 03:37pm, Yinghai Lu wrote:
> > On Mon, May 1, 2017 at 4:41 AM, Baoquan He <bhe@redhat.com> wrote:
> > >  arch/x86/mm/init_64.c | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
> > > index 15173d3..dbf4f00 100644
> > > --- a/arch/x86/mm/init_64.c
> > > +++ b/arch/x86/mm/init_64.c
> > > @@ -94,12 +94,14 @@ __setup("noexec32=", nonx32_setup);
> > >   */
> > >  void sync_global_pgds(unsigned long start, unsigned long end)
> > >  {
> > > -       unsigned long address;
> > > +       unsigned long address, address_next;
> > >
> > > -       for (address = start; address <= end; address += PGDIR_SIZE) {
> > > +       for (address = start; address <= end; address = address_next) {
> > >                 const pgd_t *pgd_ref = pgd_offset_k(address);
> > >                 struct page *page;
> > >
> > > +               address_next = (address & PGDIR_MASK) + PGDIR_SIZE;
> > > +
> > >                 if (pgd_none(*pgd_ref))
> > >                         continue;
> > >
> > 
> > This one is better than V2.
> > 
> > It would better if could rename address to addr as Ingo suggested.
> 
> Thanks for your checking and suggestion, Yinghai.
> 
> Both v1 and v2 are fine to me. As you said, code in v1 is easily
> understood, while v2 code is more compact, less line. The line of v1 is
> not more than 80. Maybe Ingo can help choose one which he likes better.

Let's do the variant I suggested - that makes the loop self-contained ('continue' 
would work as-is, etc.) and makes the code all around more readable.

Thanks,

	Ingo