From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751557AbdEBJdM (ORCPT ); Tue, 2 May 2017 05:33:12 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51287 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751117AbdEBJdG (ORCPT ); Tue, 2 May 2017 05:33:06 -0400 Date: Tue, 2 May 2017 12:32:59 +0300 From: Mike Rapoport To: "Michael Kerrisk (man-pages)" Cc: Andrea Arcangeli , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-man@vger.kernel.org Subject: Re: [PATCH man-pages 3/5] ioctl_userfaultfd.2: add BUGS section References: <1493617399-20897-1-git-send-email-rppt@linux.vnet.ibm.com> <1493617399-20897-4-git-send-email-rppt@linux.vnet.ibm.com> <345c064d-83fe-3e40-c5cb-5d4b6e5cdff4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <345c064d-83fe-3e40-c5cb-5d4b6e5cdff4@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17050209-0016-0000-0000-0000048E471A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17050209-0017-0000-0000-0000277ABF1A Message-Id: <20170502093252.GB5910@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-02_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705020055 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 01, 2017 at 08:33:50PM +0200, Michael Kerrisk (man-pages) wrote: > Hi Mike, > > I've applied this, but have a question. > > On 05/01/2017 07:43 AM, Mike Rapoport wrote: > > The features handshake is not quite convenient. > > Elaborate about it in the BUGS section. > > > > Signed-off-by: Mike Rapoport > > --- > > man2/ioctl_userfaultfd.2 | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/man2/ioctl_userfaultfd.2 b/man2/ioctl_userfaultfd.2 > > index e12b9de..50316de 100644 > > --- a/man2/ioctl_userfaultfd.2 > > +++ b/man2/ioctl_userfaultfd.2 > > @@ -650,6 +650,15 @@ operations are Linux-specific. > > .SH EXAMPLE > > See > > .BR userfaultfd (2). > > +.SH BUGS > > +In order to detect available userfault features and > > +enable certain subset of those features > > I changed "certain" to "some". ("certain subset" here also > would sound like "some particular subset" of those features.) > Okay? Yes, sure. > > +the usefault file descriptor must be closed after the first > > +.BR UFFDIO_API > > +operation that queries features availability and re-opened before > > +the second > > +.BR UFFDIO_API > > +call that actually enables the desired features. > > .SH SEE ALSO > > .BR ioctl (2), > > .BR mmap (2), > > Cheers, > > Michael > > > > -- > Michael Kerrisk > Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ > Linux/UNIX System Programming Training: http://man7.org/training/ >