From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247AbdEBJkf (ORCPT ); Tue, 2 May 2017 05:40:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6736 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbdEBJke (ORCPT ); Tue, 2 May 2017 05:40:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8214CF4356 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=ming.lei@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8214CF4356 Date: Tue, 2 May 2017 17:40:21 +0800 From: Ming Lei To: NeilBrown Cc: Jens Axboe , linux-block@vger.kernel.org, Ming Lei , linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create() Message-ID: <20170502094019.GA1803@ming.t460p> References: <149369628671.5146.4865312503373040039.stgit@noble> <149369654407.5146.12779672368228096310.stgit@noble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149369654407.5146.12779672368228096310.stgit@noble> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 02 May 2017 09:40:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 02, 2017 at 01:42:24PM +1000, NeilBrown wrote: > "flags" arguments are often seen as good API design as they allow > easy extensibility. > bioset_create_nobvec() is implemented internally as a variation in > flags passed to __bioset_create(). >>From driver's view, this flag has document benifit too. > > To support future extension, make the internal structure part of the > API. > i.e. add a 'flags' argument to bioset_create() and discard > bioset_create_nobvec(). > > Note that the bio_split allocations in drivers/md/raid* do not need > the bvec mempool - they should have used bioset_create_nobvec(). > > Suggested-by: Christoph Hellwig > Signed-off-by: NeilBrown Reviewed-by: Ming Lei Thanks, Ming