From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751344AbdEBLWW (ORCPT ); Tue, 2 May 2017 07:22:22 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:52214 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbdEBLWU (ORCPT ); Tue, 2 May 2017 07:22:20 -0400 Date: Tue, 2 May 2017 13:22:08 +0200 From: Maxime Ripard To: icenowy@aosc.io Cc: Thomas Gleixner , Rob Herring , Chen-Yu Tsai , Lee Jones , Liam Girdwood , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-kernel-owner@vger.kernel.org Subject: Re: [PATCH v5 01/10] arm64: allwinner: a64: enable RSB on A64 Message-ID: <20170502112208.km7q4inncospx673@lukather> References: <20170426152023.41567-1-icenowy@aosc.io> <20170426152023.41567-2-icenowy@aosc.io> <20170427132805.izv6xfktlhfc4yty@lukather> <4f910cd7ab972c1b6d93b0327833b596@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kux766qlxcubpkqj" Content-Disposition: inline In-Reply-To: <4f910cd7ab972c1b6d93b0327833b596@aosc.io> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kux766qlxcubpkqj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 28, 2017 at 02:14:58AM +0800, icenowy@aosc.io wrote: > =E5=9C=A8 2017-04-27 21:28=EF=BC=8CMaxime Ripard =E5=86=99=E9=81=93=EF=BC= =9A > > On Wed, Apr 26, 2017 at 11:20:14PM +0800, Icenowy Zheng wrote: > > > Allwinner A64 have a RSB controller like the one on A23/A33 SoCs. > > >=20 > > > Add it and its pinmux. > > >=20 > > > Signed-off-by: Icenowy Zheng > > > Acked-by: Chen-Yu Tsai > > > --- > > > Changes in v2: > > > - Removed bonus properties in pio node. > > > - Added Chen-Yu's ACK. > > >=20 > > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 19 > > > +++++++++++++++++++ > > > 1 file changed, 19 insertions(+) > > >=20 > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > index c7f669f5884f..05ec9fc5e81f 100644 > > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > > > @@ -422,6 +422,25 @@ > > > #gpio-cells =3D <3>; > > > interrupt-controller; > > > #interrupt-cells =3D <3>; > > > + > > > + r_rsb_pins: rsb@0 { > > > + pins =3D "PL0", "PL1"; > > > + function =3D "s_rsb"; > > > + }; > > > + }; > > > + > > > + r_rsb: rsb@1f03400 { > > > + compatible =3D "allwinner,sun8i-a23-rsb"; > > > + reg =3D <0x01f03400 0x400>; > > > + interrupts =3D ; > > > + clocks =3D <&r_ccu 6>; > >=20 > > Please use the defines here.. >=20 > Linux-4.12 doesn't yet enter rc1, and the defines are still not in > Linus's tree. >=20 > Please note that I have already mentioned that this patch is necessary > to be merged into 4.12, otherwise poweroff won't work properly at 4.12 . This is too late for 4.12. We don't merge any patch two weeks before the merge window opens, which makes it around -rc6. This will be 4.13 material, so we'll definitely have the defines by then. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --kux766qlxcubpkqj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJZCGvcAAoJEBx+YmzsjxAgQoUQAKixNoCm/HULeW2dXqlbkV6H NSpTXM5r0Hpq75N9qtXd3sdgE5zWxDwJQ5kz1xMQBQUEx8zhMA38d6vVCeJA8NRM BJpcIO9Pgxma35IUzvqV00EkCdmst2skytT/r69u+XmgnGzNI8QIaXAMcnPveCy/ HS9KEDAevm+H36d8J8AcNAp+7h/deWlWppAY6wzeeM1tmDRN0nED/jutwr6tSIVq yTEW7/ewEekMQ2YFFOFapVeBSxI1myUWaNYOJtevKoi3J48Ip4ti4/wSoy4P6au2 jeLiLpmK7taCco1SUElSodHts1BxgO3PcDf6MQTKjyFeXgVCIhpxHvzFvCy7kdH9 AhNu5JSbOqLcpBjS5wdXjzn2tUWJQBqt2hu11Ewcj0KB+ifwf2MEIfxl+hvY0CiX d+eQNzQMlCezu+9aRiB2IlliJk9lKyL4zNbKzPnvOuKwbqA/fP7Xty7+irtycpq+ QWkJUfjdfhtMZG4+HsTxOmd48yAYU8gMdkaiLehCiRBHt5ZadQwT4WX3TmY88oHA Ly+MpDxjJ7fyKESETwdfT5dkELpo9A7tLD0duXMgdBc8TxOGOjy8qp2gN6+GMPdY /xIa3Toyoq6ggacZMTaqlVm+uYrvBHNDBoEYSXGpUTrLufxbSL04e03I4tGm/5fW Q5AYo0xb6erPETadHqqS =t/KP -----END PGP SIGNATURE----- --kux766qlxcubpkqj--