From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751483AbdEBL7x (ORCPT ); Tue, 2 May 2017 07:59:53 -0400 Received: from mail.skyhub.de ([5.9.137.197]:53800 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdEBL7u (ORCPT ); Tue, 2 May 2017 07:59:50 -0400 Date: Tue, 2 May 2017 13:59:44 +0200 From: Borislav Petkov To: Alexey Dobriyan Cc: the arch/x86 maintainers , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Linux Kernel Subject: Re: [PATCH 2/5] x86_64: inline copy_page() at call site Message-ID: <20170502115944.GC6485@nazgul.tnic> References: <20170426182318.GA5069@avx2> <20170426182806.GB5069@avx2> <20170428210409.ap3bnb4i3l4gm36p@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 02, 2017 at 02:49:04PM +0300, Alexey Dobriyan wrote: > It says unambiguously which instruction does the actual copying. And that doesn't tell me that it is an unrolled moving using registers. And that is much more useful info when I look at stack traces than just "mov". -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --