From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbdECMtm (ORCPT ); Wed, 3 May 2017 08:49:42 -0400 Received: from mga01.intel.com ([192.55.52.88]:4291 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbdECMtd (ORCPT ); Wed, 3 May 2017 08:49:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,284,1491289200"; d="scan'208";a="95034435" Date: Wed, 3 May 2017 15:49:29 +0300 From: Jarkko Sakkinen To: Roberto Sassu Cc: tpmdd-devel@lists.sourceforge.net, linux-ima-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] tpm: move TPM 1.2 code of tpm_pcr_extend() to tpm1_pcr_extend() Message-ID: <20170503124929.4fkyb4fgtolyp3a5@intel.com> References: <20170502123151.24354-1-roberto.sassu@huawei.com> <20170502123151.24354-4-roberto.sassu@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170502123151.24354-4-roberto.sassu@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 02, 2017 at 02:31:51PM +0200, Roberto Sassu wrote: > In preparation of the modifications to tpm_pcr_extend(), which will > allow callers to supply a digest for each PCR bank of a TPM 2.0, > the TPM 1.2 specific code has been moved to tpm1_pcr_extend(). > > tpm1_pcr_extend() uses tpm_buf_init() to prepare the command buffer, > which offers protection against buffer overflow. It is called by > tpm_pcr_extend() and tpm_pm_suspend(). > > Signed-off-by: Roberto Sassu Reviewed-by: Jarkko Sakkinen /Jarkko > --- > drivers/char/tpm/tpm-interface.c | 46 +++++++++++++++++++++------------------- > 1 file changed, 24 insertions(+), 22 deletions(-) > > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c > index 5c2c032..9059f67 100644 > --- a/drivers/char/tpm/tpm-interface.c > +++ b/drivers/char/tpm/tpm-interface.c > @@ -763,11 +763,25 @@ EXPORT_SYMBOL_GPL(tpm_pcr_read); > > #define EXTEND_PCR_RESULT_SIZE 34 > #define EXTEND_PCR_RESULT_BODY_SIZE 20 > -static const struct tpm_input_header pcrextend_header = { > - .tag = cpu_to_be16(TPM_TAG_RQU_COMMAND), > - .length = cpu_to_be32(34), > - .ordinal = cpu_to_be32(TPM_ORD_PCREXTEND) > -}; > + > +static int tpm1_pcr_extend(struct tpm_chip *chip, int pcr_idx, const u8 *hash, > + char *log_msg) > +{ > + struct tpm_buf buf; > + int rc; > + > + rc = tpm_buf_init(&buf, TPM_TAG_RQU_COMMAND, TPM_ORD_PCREXTEND); > + if (rc) > + return rc; > + > + tpm_buf_append_u32(&buf, pcr_idx); > + tpm_buf_append(&buf, hash, TPM_DIGEST_SIZE); > + > + rc = tpm_transmit_cmd(chip, buf.data, EXTEND_PCR_RESULT_SIZE, > + EXTEND_PCR_RESULT_BODY_SIZE, 0, log_msg); > + tpm_buf_destroy(&buf); > + return rc; > +} > > /** > * tpm_pcr_extend - extend pcr value with hash > @@ -781,7 +795,6 @@ static const struct tpm_input_header pcrextend_header = { > */ > int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash) > { > - struct tpm_cmd_t cmd; > int rc; > struct tpm_chip *chip; > struct tpm2_digest digest_list[ARRAY_SIZE(chip->active_banks)]; > @@ -807,13 +820,8 @@ int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash) > return rc; > } > > - cmd.header.in = pcrextend_header; > - cmd.params.pcrextend_in.pcr_idx = cpu_to_be32(pcr_idx); > - memcpy(cmd.params.pcrextend_in.hash, hash, TPM_DIGEST_SIZE); > - rc = tpm_transmit_cmd(chip, &cmd, EXTEND_PCR_RESULT_SIZE, > - EXTEND_PCR_RESULT_BODY_SIZE, 0, > - "attempting extend a PCR value"); > - > + rc = tpm1_pcr_extend(chip, pcr_idx, hash, > + "attempting extend a PCR value"); > tpm_put_ops(chip); > return rc; > } > @@ -1011,15 +1019,9 @@ int tpm_pm_suspend(struct device *dev) > } > > /* for buggy tpm, flush pcrs with extend to selected dummy */ > - if (tpm_suspend_pcr) { > - cmd.header.in = pcrextend_header; > - cmd.params.pcrextend_in.pcr_idx = cpu_to_be32(tpm_suspend_pcr); > - memcpy(cmd.params.pcrextend_in.hash, dummy_hash, > - TPM_DIGEST_SIZE); > - rc = tpm_transmit_cmd(chip, &cmd, EXTEND_PCR_RESULT_SIZE, > - EXTEND_PCR_RESULT_BODY_SIZE, 0, > - "extending dummy pcr before suspend"); > - } > + if (tpm_suspend_pcr) > + rc = tpm1_pcr_extend(chip, tpm_suspend_pcr, dummy_hash, > + "extending dummy pcr before suspend"); > > /* now do the actual savestate */ > for (try = 0; try < TPM_RETRY; try++) { > -- > 2.9.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-security-module" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html