From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753699AbdECWQj (ORCPT ); Wed, 3 May 2017 18:16:39 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:54667 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbdECWQc (ORCPT ); Wed, 3 May 2017 18:16:32 -0400 Date: Thu, 4 May 2017 00:16:20 +0200 From: Alexandre Belloni To: Shawn Guo Cc: Gary Bisson , Sascha Hauer , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Message-ID: <20170503221620.k3gf3s7lramlgfyf@piout.net> References: <20170419202204.7689-1-alexandre.belloni@free-electrons.com> <20170503085010.GF18578@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170503085010.GF18578@dragon> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2017 at 16:50:12 +0800, Shawn Guo wrote: > On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote: > > The rv4162 vendor is microcrystal, not ST. > > > > Signed-off-by: Alexandre Belloni > > --- > > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > > index bad3c9f9eeac..b63134e3b51a 100644 > > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi > > @@ -408,7 +408,7 @@ > > }; > > > > rtc: rtc@68 { > > - compatible = "st,rv4162"; > > + compatible = "microcrystal,rv4162"; > > The compatible is not documented? > No, it wasn't. Like for many i2c devices, the driver predates DT and didn't need any specific code to be used from DT. Basically, the i2c core was using the i2c_device_ids to match the DT compatible string. This is changing since cabcf4f6be658b2d4bea26dee89d08fdf67d6811. I'm planning to document all the undocumented ones soon. > Shawn > > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_rv4162>; > > reg = <0x68>; > > -- > > 2.11.0 > > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com