From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: tpmdd-devel@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
jgunthorpe@obsidianresearch.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] tpm: vtpm_proxy: Add ioctl to get supported flags
Date: Thu, 4 May 2017 01:31:24 +0300 [thread overview]
Message-ID: <20170503223124.uoembffcifw5yx4t@intel.com> (raw)
In-Reply-To: <1493384538-27883-2-git-send-email-stefanb@linux.vnet.ibm.com>
On Fri, Apr 28, 2017 at 09:02:16AM -0400, Stefan Berger wrote:
> Add an ioctl to get the supported flags.
>
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
The commit message is a bit lacking on explaining things like why we
need it.
> ---
> drivers/char/tpm/tpm_vtpm_proxy.c | 29 +++++++++++++++++++++++++++++
> include/uapi/linux/vtpm_proxy.h | 11 +++++++++++
> 2 files changed, 40 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c b/drivers/char/tpm/tpm_vtpm_proxy.c
> index 751059d..fb4d207 100644
> --- a/drivers/char/tpm/tpm_vtpm_proxy.c
> +++ b/drivers/char/tpm/tpm_vtpm_proxy.c
> @@ -592,6 +592,33 @@ static long vtpmx_ioc_new_dev(struct file *file, unsigned int ioctl,
> return 0;
> }
>
> +/**
> + * vtpmx_ioc_get_supt_flags - handler for the %VTPM_PROXY_IOC_GET_SUPT_FLAGS
> + * ioctl
> + * @file: /dev/vtpmx
> + * @ioctl: the ioctl number
> + * @arg: pointer to the struct vtpmx_proxy_get_supt_flags
> + *
> + * Return the bitfield of supported flags
> + */
> +static long vtpmx_ioc_get_supt_flags(struct file *file, unsigned int ioctl,
> + unsigned long arg)
> +{
> + void __user *argp = (void __user *)arg;
> + struct vtpm_proxy_supt_flags __user *vtpm_supt_flags_p = argp;
> + struct vtpm_proxy_supt_flags flags = {
> + .flags = VTPM_PROXY_FLAGS_ALL,
> + };
> +
> + if (!capable(CAP_SYS_ADMIN))
> + return -EPERM;
> +
> + if (copy_to_user(vtpm_supt_flags_p, &flags, sizeof(flags)))
> + return -EFAULT;
> +
> + return 0;
> +}
> +
> /*
> * vtpmx_fops_ioctl: ioctl on /dev/vtpmx
> *
> @@ -604,6 +631,8 @@ static long vtpmx_fops_ioctl(struct file *f, unsigned int ioctl,
> switch (ioctl) {
> case VTPM_PROXY_IOC_NEW_DEV:
> return vtpmx_ioc_new_dev(f, ioctl, arg);
> + case VTPM_PROXY_IOC_GET_SUPT_FLAGS:
> + return vtpmx_ioc_get_supt_flags(f, ioctl, arg);
> default:
> return -ENOIOCTLCMD;
> }
> diff --git a/include/uapi/linux/vtpm_proxy.h b/include/uapi/linux/vtpm_proxy.h
> index a69e991..83e64e7 100644
> --- a/include/uapi/linux/vtpm_proxy.h
> +++ b/include/uapi/linux/vtpm_proxy.h
> @@ -44,6 +44,17 @@ struct vtpm_proxy_new_dev {
> __u32 minor; /* output */
> };
>
> +/**
> + * struct vtpm_proxy_supt_flags - parameter structure for the
> + * %VTPM_PROXY_IOC_GET_SUPT_FLAGS ioctl
> + * @flags: flags supported by the vtpm proxy driver
> + */
> +struct vtpm_proxy_supt_flags {
> + __u32 flags; /* output */
> +};
> +
> #define VTPM_PROXY_IOC_NEW_DEV _IOWR(0xa1, 0x00, struct vtpm_proxy_new_dev)
> +#define VTPM_PROXY_IOC_GET_SUPT_FLAGS \
> + _IOR(0xa1, 0x01, struct vtpm_proxy_supt_flags)
>
> #endif /* _UAPI_LINUX_VTPM_PROXY_H */
> --
> 2.4.3
>
/Jarkko
next prev parent reply other threads:[~2017-05-03 22:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 13:02 [PATCH v2 0/3] Extend the vTPM proxy driver to pass locality to emulator Stefan Berger
2017-04-28 13:02 ` [PATCH v2 1/3] tpm: vtpm_proxy: Add ioctl to get supported flags Stefan Berger
2017-05-03 22:31 ` Jarkko Sakkinen [this message]
2017-04-28 13:02 ` [PATCH v2 2/3] tpm: vtpm_proxy: Implement request_locality Stefan Berger
2017-04-28 13:02 ` [PATCH v2 3/3] tpm: vtpm_proxy: Add ioctl to request locality prepended to command Stefan Berger
2017-04-29 7:02 ` kbuild test robot
2017-05-03 22:37 ` Jarkko Sakkinen
2017-05-03 23:40 ` Stefan Berger
2017-05-04 9:17 ` Jarkko Sakkinen
2017-05-04 11:14 ` Stefan Berger
2017-05-04 18:40 ` Jarkko Sakkinen
2017-05-04 20:03 ` Stefan Berger
2017-05-08 23:43 ` Jarkko Sakkinen
2017-05-09 15:49 ` Stefan Berger
2017-05-10 12:47 ` Jarkko Sakkinen
2017-05-10 13:20 ` Stefan Berger
2017-05-10 18:33 ` Jarkko Sakkinen
2017-04-29 11:58 ` [PATCH v2 0/3] Extend the vTPM proxy driver to pass locality to emulator Jarkko Sakkinen
2017-05-03 22:38 ` Jarkko Sakkinen
2017-05-03 23:42 ` Stefan Berger
2017-05-04 9:18 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503223124.uoembffcifw5yx4t@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).